Skip to content

do not throw exception if trying to dequeue an empty intra-process buffer - #2061

Merged
alsora merged 1 commit into
rollingfrom
asoragna/relax-ipc-buffer
Dec 21, 2022
Merged

alsora merged 1 commit into
rollingfrom
asoragna/relax-ipc-buffer

Conversation

@alsora

@alsora alsora commented Dec 9, 2022

Copy link
Copy Markdown
Collaborator

do not throw exception if trying to dequeue an empty intra-process buffer

this PR enforces the same behavior that we already follow for non-ipc messages: there, the take_and_do_error_handling function handles gracefully trying to get data when it's not available.

Signed-off-by: Alberto Soragna alberto.soragna@gmail.com

…ffer

Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
@ivanpauno

Copy link
Copy Markdown
Member

LGTM with green CI (please test --packages-above rclcpp)

@alsora

alsora commented Dec 14, 2022

Copy link
Copy Markdown
Collaborator Author

CI

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@alsora

alsora commented Dec 19, 2022

Copy link
Copy Markdown
Collaborator Author

Retry CI as the failure seems unrelated

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@ivanpauno

Copy link
Copy Markdown
Member

Retry CI as the failure seems unrelated

Yes, that one seems unrelated, you can ignore it.

@alsora

alsora commented Dec 21, 2022

Copy link
Copy Markdown
Collaborator Author

Merging this as we have green CI.

@alsora
alsora merged commit 3fb012e into rolling Dec 21, 2022
@delete-merged-branch
delete-merged-branch Bot deleted the asoragna/relax-ipc-buffer branch December 21, 2022 10:11
@fujitatomoya

Copy link
Copy Markdown
Collaborator

@alsora do we want to backport this to humble?

@alsora

alsora commented Dec 22, 2022

Copy link
Copy Markdown
Collaborator Author

This inconsistency has always been there (i.e. both in Humble and Galactic).

The backport to humble should be conflicts-free, so yes we could do it.

@fujitatomoya

Copy link
Copy Markdown
Collaborator

@Mergifyio backport humble

@mergify

mergify Bot commented Dec 22, 2022

Copy link
Copy Markdown
Contributor

backport humble

✅ Backports have been created

Details

mergify Bot pushed a commit that referenced this pull request Dec 22, 2022
…ffer (#2061)

Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>

Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
(cherry picked from commit 3fb012e)
fujitatomoya pushed a commit that referenced this pull request Dec 22, 2022
…ffer (#2061) (#2070)

Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>

Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
(cherry picked from commit 3fb012e)

Co-authored-by: Alberto Soragna <alberto.soragna@gmail.com>
bartalor pushed a commit to bartalor/rclcpp that referenced this pull request Jul 15, 2026
…ffer (ros2#2061)

Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>

Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants