Skip to content

Fix SharedFuture from async_send_request never becomes valid - #2044

Merged
fujitatomoya merged 1 commit into
ros2:rollingfrom
llapx:topic-2039
Dec 2, 2022
Merged

fujitatomoya merged 1 commit into
ros2:rollingfrom
llapx:topic-2039

Conversation

@llapx

@llapx llapx commented Nov 7, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Lei Liu Lei.Liu.AP@sony.com

Signed-off-by: Lei Liu <Lei.Liu.AP@sony.com>
@llapx

llapx commented Nov 7, 2022

Copy link
Copy Markdown
Contributor Author

It seems Jenkins broken:

17:21:20 FATAL: command execution failed
17:26:12 java.nio.channels.ClosedChannelException
17:26:12 	at org.jenkinsci.remoting.protocol.impl.ChannelApplicationLayer.onReadClosed(ChannelApplicationLayer.java:209)
17:26:12 	at org.jenkinsci.remoting.protocol.ApplicationLayer.onRecvClosed(ApplicationLayer.java:221)
17:26:12 	at org.jenkinsci.remoting.protocol.ProtocolStack$Ptr.onRecvClosed(ProtocolStack.java:817)
17:26:12 	at org.jenkinsci.remoting.protocol.FilterLayer.onRecvClosed(FilterLayer.java:288)

Can anybody fix it?

@clalancette

Copy link
Copy Markdown
Contributor

It seems Jenkins broken:

With those sorts of errors, Jenkins will automatically re-run it, and it did. The latest one is failing because test_time_source failed. That probably bears looking into.

@fujitatomoya fujitatomoya left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fujitatomoya

Copy link
Copy Markdown
Collaborator

@iuhilnehc-ynos can you run CI for this?

@iuhilnehc-ynos

Copy link
Copy Markdown
Collaborator

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya

Copy link
Copy Markdown
Collaborator

@iuhilnehc-ynos can you review this? i need another review before merge.

@fujitatomoya
fujitatomoya merged commit 66b1944 into ros2:rolling Dec 2, 2022
@MiguelCompany

Copy link
Copy Markdown
Contributor

@fujitatomoya Should this be backported?

@fujitatomoya

Copy link
Copy Markdown
Collaborator

@Mergifyio backport to humble

@mergify

mergify Bot commented Jan 3, 2023

Copy link
Copy Markdown
Contributor

backport to humble

✅ Backports have been created

Details

mergify Bot pushed a commit that referenced this pull request Jan 3, 2023
Signed-off-by: Lei Liu <Lei.Liu.AP@sony.com>
(cherry picked from commit 66b1944)
jefferyyjhsu pushed a commit to irobot-ros/rclcpp that referenced this pull request Jan 3, 2023
fujitatomoya pushed a commit that referenced this pull request Jan 6, 2023
…2076)

Signed-off-by: Lei Liu <Lei.Liu.AP@sony.com>
(cherry picked from commit 66b1944)

Co-authored-by: Lei Liu <64953129+llapx@users.noreply.github.com>
alsora pushed a commit to irobot-ros/rclcpp that referenced this pull request Apr 29, 2023
tkimura4 pushed a commit to tier4/rclcpp that referenced this pull request Aug 29, 2023
…) (ros2#2076)

Signed-off-by: Lei Liu <Lei.Liu.AP@sony.com>
(cherry picked from commit 66b1944)

Co-authored-by: Lei Liu <64953129+llapx@users.noreply.github.com>
tkimura4 added a commit to tier4/rclcpp that referenced this pull request Aug 30, 2023
…) (ros2#2076) (#6)

(cherry picked from commit 66b1944)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Lei Liu <64953129+llapx@users.noreply.github.com>
bartalor pushed a commit to bartalor/rclcpp that referenced this pull request Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants