Skip to content

support regex match for parameter client - #1992

Merged
fujitatomoya merged 4 commits into
ros2:rollingfrom
iuhilnehc-ynos:topic-parameter-client-params-file
Sep 8, 2022
Merged

fujitatomoya merged 4 commits into
ros2:rollingfrom
iuhilnehc-ynos:topic-parameter-client-params-file

Conversation

@iuhilnehc-ynos

@iuhilnehc-ynos iuhilnehc-ynos commented Aug 17, 2022 •

Copy link
Copy Markdown
Collaborator

to implement #1997

Signed-off-by: Chen Lihui lihui.chen@sony.com

@fujitatomoya

Copy link
Copy Markdown
Collaborator

@iuhilnehc-ynos there are conflicts on this PR, could you address it? and do we have issue or reference against this PR?

@iuhilnehc-ynos
iuhilnehc-ynos force-pushed the topic-parameter-client-params-file branch from 60e2c8c to 0f42d78 Compare August 18, 2022 05:21
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
@iuhilnehc-ynos

Copy link
Copy Markdown
Collaborator Author

and do we have issue or reference against this PR?

No, I didn't create an issue. Thanks for mentioning it. I am going to create it.

@fujitatomoya

Copy link
Copy Markdown
Collaborator

@iuhilnehc-ynos yeah it would be nice for reviewers to describe what exactly we are addressing to. it does not have to be issue, i think we can add description on this PR too. thanks!

@iuhilnehc-ynos iuhilnehc-ynos linked an issue Aug 18, 2022 that may be closed by this pull request

@fujitatomoya fujitatomoya left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, can you run CI?

Comment thread rclcpp/src/rclcpp/parameter_client.cpp Resolved

@ivanpauno ivanpauno left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above comment

Chen Lihui added 3 commits August 20, 2022 11:01
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>

@ivanpauno ivanpauno left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@iuhilnehc-ynos

Copy link
Copy Markdown
Collaborator Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette

Copy link
Copy Markdown
Contributor

@iuhilnehc-ynos I think this is set to go, so feel free to merge when you are ready.

@fujitatomoya
fujitatomoya merged commit 92d4f3e into ros2:rolling Sep 8, 2022
bartalor pushed a commit to bartalor/rclcpp that referenced this pull request Jul 15, 2026
* support regex match for parameter client

Signed-off-by: Chen Lihui <lihui.chen@sony.com>

* address review that change behavior of a public method

Signed-off-by: Chen Lihui <lihui.chen@sony.com>

* remove an unnecessary comment

Signed-off-by: Chen Lihui <lihui.chen@sony.com>

* update gmock compilation setting

Signed-off-by: Chen Lihui <lihui.chen@sony.com>

Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support regex match for parameter client

4 participants