You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The first release was installed with debian package installation (https://index.ros.org/doc/ros2/Installation/Dashing/Linux-Install-Debians/).
I cloned the examples repo and built it with colcon. I used the first release binaries of ROS2 as environment.
Now I tried with newer release of ROS2 Dashing with 'apt upgrade' command and same problem occurs.
I think I should try building ROS2 from source.
I tried with ROS2 built from source (latest-release) and the example above(running with MultiThreadedExecutor) worked fine.
Thanks for checking it! I will try to figure out what PR solved the problem, and add it to the patch release 2 list (if it's not already there).
@ivanpauno if they were building release-latest from source then it should be identical to the current dashing release and there wouldn't be any PRs that are not already part of the binaries.
@ivanpauno if they were building release-latest from source then it should be identical to the current dashing release and there wouldn't be any PRs that are not already part of the binaries.
I didn't try with release-latest. I just checked with master (from source), and it was working.
This fix was released in Dashing Patch 4 but the issue wasn't removed from the board so it got bumped forward. I'm taking it off now but the fix was released.
Activity
gavanderhoorn commentedon Jul 9, 2019
Context: [ros2] multi threaded executor with single node always makes the wall-timer hung. on ROS Answers.
Related (according to OP): #702.
ivanpauno commentedon Jul 9, 2019
I couldn't reproduce the problem in master.
Did you use the binaries of the first release, or Dashing release patch 1 binaries?
Did you only download this repo (
examples) and build it in a overlay workspace of the binary installation? Please, share details of how you built it.Mygao commentedon Jul 10, 2019
The first release was installed with debian package installation (https://index.ros.org/doc/ros2/Installation/Dashing/Linux-Install-Debians/).
I cloned the examples repo and built it with colcon. I used the first release binaries of ROS2 as environment.
Now I tried with newer release of ROS2 Dashing with 'apt upgrade' command and same problem occurs.
I think I should try building ROS2 from source.
Mygao commentedon Jul 11, 2019
I tried with ROS2 built from source (latest-release) and the example above(running with MultiThreadedExecutor) worked fine.
ivanpauno commentedon Jul 11, 2019
I will also try from binaries, to double check.
Thanks for checking it! I will try to figure out what PR solved the problem, and add it to the patch release 2 list (if it's not already there).
ivanpauno commentedon Jul 11, 2019
I confirm that it isn't working when installing from debians. I have not clue about what PR solved the problem.
nuclearsandwich commentedon Jul 25, 2019
@ivanpauno if they were building
release-latestfrom source then it should be identical to the current dashing release and there wouldn't be any PRs that are not already part of the binaries.@Mygao or @ivanpauno have either of you tried reproducing this issue with the Dashing binary archive? https://github.com/ros2/ros2/releases/tag/release-dashing-20190614
That might add an additional data point.
ivanpauno commentedon Jul 25, 2019
I didn't try with
release-latest. I just checked withmaster(from source), and it was working.No, I only tried with debians. I haven't tried with the binary archive.
nuclearsandwich commentedon Jul 25, 2019
Trying with release-latest from source to confirm @Mygao's findings seems prudent as well to avoid chasing shadows.
ivanpauno commentedon Jul 25, 2019
I tried from source using
release-latest, and I couldn't reproduce the bug.ivanpauno commentedon Sep 13, 2019
@Mygao could you check if this is still happening after the last patch release?
oceanusxiv commentedon Sep 24, 2019
@ivanpauno I actually just ran into this issue and I'm using the latest debian of dashing as far as I can tell
oceanusxiv commentedon Sep 24, 2019
OK so I just found this #836 which is the PR that fixed this issue. So it looks like we should probably put this in the patch release
EDIT: oops I see that you're already aware of this. Sorry for bothering you XD
ivanpauno commentedon Sep 24, 2019
Thanks for the comment @eric1221bday, I didn't realize that #836 was a fix for this.
I created the backport PR in #869.
I'm closing this!
nuclearsandwich commentedon Dec 5, 2019
This fix was released in Dashing Patch 4 but the issue wasn't removed from the board so it got bumped forward. I'm taking it off now but the fix was released.
Don't overwrite cur_ns pointer if reallocation fails (ros2#780)
Refactor parser.c for better testability (ros2#754)