Skip to content

Subscriptions are not triggered sometimes #52

Closed
ros2/rmw_connext
#66

Description

@esteve

In the parameter events examples, the callback function is not always triggered. However further testing shows that the data was received, but the executor didn't trigger the callback. This may indicate that there's an issue in the way SingleThreadedExceutor is used.

Activity

  1. self-assigned this
    on Jun 30, 2015
  2. gerkey commented on Jul 7, 2015

    @gerkey
    Member

    Happens in OpenSplice and Connext, so it's likely in our code somewhere. Consider writing a test that reproduces the problem. Also walk somebody else on the team through the problem.

  3. dirk-thomas commented on Jul 30, 2015

    @dirk-thomas
    Member

    The same fix as implemented for subscriptions (ros2/rmw_connext#62 ros2/rmw_opensplice#57) needs to be applied for server and client.

  4. added
    in reviewWaiting for review (Kanban column)
    and removed
    in progressActively being worked on (Kanban column)
    on Aug 3, 2015
  5. dirk-thomas commented on Aug 4, 2015

    @dirk-thomas
    Member

    We will try to write a test which fails before and passes afterwards. E.g. similar to the subscription: calling two services, spin and likely the second request is never be handled.

  6. added
    readyWork is about to start (Kanban column)
    and removed
    in reviewWaiting for review (Kanban column)
    on Aug 18, 2015
  7. added
    in progressActively being worked on (Kanban column)
    and removed
    readyWork is about to start (Kanban column)
    on Aug 21, 2015
  8. 1 remaining item

  9. added
    readyWork is about to start (Kanban column)
    on Sep 17, 2015
  10. removed
    readyWork is about to start (Kanban column)
    on Oct 13, 2015
  11. dirk-thomas commented on Oct 15, 2015

    @dirk-thomas
    Member

    I implemented the test in ros2/system_tests#45.

  12. removed
    in reviewWaiting for review (Kanban column)
    on Oct 15, 2015
  13. self-assigned this
    on Oct 15, 2015
  14. reopened this on Oct 15, 2015
  15. dirk-thomas commented on Oct 15, 2015

    @dirk-thomas
    Member

    @esteve Can you please test the original problem related to parameter events again with the patches being merged and either close this ticket or fill in more information what still doesn't work.

  16. removed
    in reviewWaiting for review (Kanban column)
    on Oct 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions