You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Expose timeout option for parameter service calls by SyncParametersClient #360
As an example, SyncParametersClient::set_parameters doesn't take a timeout option. So, if anything goes wrong in the service call (e.g. the server goes down), we will get stuck waiting indefinitely.
Parameter tests in test_rclcpp (e.g. this one) should be updated to specify a timeout, so that the other tests in the file can be run even if one of them hangs.
Activity
wjwwood commentedon Mar 19, 2020
Updated link:
rclcpp/rclcpp/src/rclcpp/parameter_client.cpp
Lines 453 to 468 in 96ebf59
fujitatomoya commentedon Dec 22, 2020
@wjwwood
thanks for the review, i think we can close this.
Fix logic that moves goal handles when one expires (ros2#360)
Security directory lookup improvements (ros2#332)
use ament_export_targets() (ros2#360)