Skip to content

SEGFAULT in prune_requests_older_than() if pruned_requests are not provided #2007

Closed

Description

@akela1101

Segfault happens here:

pruned_requests->push_back(it->first);

, if prune_requests_older_than() is called with default argument, while there's matching request to prune:

client->prune_requests_older_than(someTimeAgo /*, nullptr by default */);

The documentation says

[inout] pruned_requests Removed requests id will be pushed to the vector if a pointer is provided.

So I assume no pointer is a valid input.

Activity

  1. clalancette commented on Aug 30, 2022

    @clalancette
    Contributor

    It's hard for me to tell exactly what your problem is from the description.

    Nevertheless, if you have a fix that you'd like to see applied, the best thing to do is to create the fix and open it against the rolling branch. Make sure you explain exactly what problem you were having, and how your change fixes it.

    Assuming it is reviewed and accepted there, it can be considered for backport to the other stable branches.

  2. akela1101 commented on Aug 30, 2022

    @akela1101
    ContributorAuthor

    I updated the description and added a PR. Please, check.

  3. clalancette commented on Aug 30, 2022

    @clalancette
    Contributor

    I updated the description and added a PR. Please, check.

    Thanks, that is appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions