Skip to content

Fix include order for cpplint - #192

Merged
jacobperron merged 2 commits into
ros2from
jacob/update_cpplint_fork
Jan 12, 2022
Merged

jacobperron merged 2 commits into
ros2from
jacob/update_cpplint_fork

Conversation

@jacobperron

Copy link
Copy Markdown
Contributor

Relates to ament/ament_lint#324

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron

Copy link
Copy Markdown
Contributor Author

The appveyor job has been failing since August 2020 (#164). Perhaps we should just remove it considering we have Windows coverage via ci.ros2.org?

@gbiggs gbiggs left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gbiggs

gbiggs commented Jan 12, 2022

Copy link
Copy Markdown

CI:

  • Linux Build Status
  • Linux (aarch64) Build Status
  • Windows Build Status

@gbiggs

gbiggs commented Jan 12, 2022

Copy link
Copy Markdown

What is the Appveyor job supposed to do?

@jacobperron

Copy link
Copy Markdown
Contributor Author

What is the Appveyor job supposed to do?

Test the package on Windows, I suppose. It was added in 2015 (#28); though it doesn't predate ci.ros2.org, so maybe it was supposed to provide additional test coverage. @wjwwood I know it's ancient history, but do you know the origin story?

@jacobperron
jacobperron merged commit 99c0d03 into ros2 Jan 12, 2022
@jacobperron
jacobperron deleted the jacob/update_cpplint_fork branch January 12, 2022 22:24
@wjwwood

wjwwood commented Jan 12, 2022

Copy link
Copy Markdown
Member

Not sure, but it may have been just covering class_loader itself before we were running ci.ros2.org on everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants