Skip to content

fix CI missing catkin_pkg and console_bridge_vendor - #105

Closed
dirk-thomas wants to merge 2 commits into
ros2from
fix_ci_catkin_pkg
Closed

dirk-thomas wants to merge 2 commits into
ros2from
fix_ci_catkin_pkg

Conversation

@dirk-thomas

Copy link
Copy Markdown
Member

As mentioned in #103 (comment)

@dirk-thomas dirk-thomas changed the title fix CI missing catkin_pkg fix CI missing catkin_pkg and console_bridge_vendor Sep 7, 2018
@dirk-thomas

Copy link
Copy Markdown
Member Author

@mikaelarguedas @nuclearsandwich I am not sure if / how the CI build is supposed to work on macOS for this repo. I tried to at least install the missing catkin_pkg package as well as clone console_bridge_vendor but it seems to not be enough. I will leave it up to you to follow up on this PR (and the referenced bugfix PR).

@dirk-thomas dirk-thomas removed their assignment Sep 7, 2018
@mikaelarguedas

mikaelarguedas commented Sep 10, 2018 •

Copy link
Copy Markdown
Member

It looks like travis doesnt support Python for MacOS at the moment: travis-ci/travis-ci#2312 (brew workaround detailed at travis-ci/travis-ci#2312 (comment)).

This has been broken for a long time and never made it up the priority list (the bouncy branch is using build.ros2.org for testing and the ros2 branch is currently tested manually with ci.ros2.org like the other ros2 repos).

Maybe this PR is a good time to consider using colcon instead of a local build of ament_tools?

@mikaelarguedas

Copy link
Copy Markdown
Member

see #106 for a PR superseeding this one

@mikaelarguedas

Copy link
Copy Markdown
Member

closing as #106 addressed the CI issues. thanks @dirk-thomas and @yechun1 for reporting

@mikaelarguedas
mikaelarguedas deleted the fix_ci_catkin_pkg branch September 14, 2018 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants