Repository navigation
Conversation
For more information, refer to ros-visualization/python_qt_binding#13 and ros-visualization/python_qt_binding#15
There was a problem hiding this comment.
This fails on Arch. /usr/share/sip contains several directories:
Py2-PyQt4Py2-PyQt5PyQt4PyQt5Qwt5
I had to set "pyqt_sip_dir" to "/usr/share/sip/Py2-PyQt4" to fix the compilation of rviz.
cc @v01d
|
Note: this PR aims at solving #13. |
|
/usr/share/sip/PyQt4 is what's used by Ubuntu Utopic, so I've updated the path to that. |
|
If I'm not mistaken, I guess that if this is the only part really specific for Arch, I can just keep a good ol' |
|
But as you said on the AUR, if sip files in /usr/share/*PyQt4 are identical, this could be solved in Arch's PyQt4 package. |
|
Superseded by #21. |
Starting in PyQt 4.11, there is no pyqtconfig, so this patch imitates it when its not found.
pyqtconfig.QtGuiModuleMakefile simply calls sipconfig.SIPModuleMakefile with qt=['QtCore', 'QtGui'],
thus this patches has no effect if pyqtconfig is found (i.e. if the user has PyQt <=4.10)