Skip to content

cmake/sip_configure.py calls non standard 'qmake-qt4' #22

Closed
Closed
cmake/sip_configure.py calls non standard 'qmake-qt4'#22

Description

@aballier
aballier
opened on Apr 29, 2015

python_qt_binding has been fixed for recent pyqt versions, thanks for that, however it has been done in a way that calls 'qmake-qt4' (instead of just 'qmake') which seems to be an invention of some distributions ( seen e.g. on https://wiki.archlinux.org/index.php/Qt#Installation and https://wiki.archlinux.org/index.php/Qt#Default_Qt_toolkit ) and that I don't have.

I am not sure how this should be fixed, archlinux wiki mentions a QT_SELECT environment variable, so maybe just calling 'qmake' with this variable set would work.

Activity

  1. dirk-thomas commented on Apr 29, 2015

    @dirk-thomas
    dirk-thomas
    on Apr 29, 2015
    Contributor

    Since this seems to be specific to whatever system you are using (and I have no way to check / confirm if a change works for you) can you please try your proposed change and report back if it works?

    Providing a PR for hit would be highly appreciated and likely speed up the process 😉

  2. aballier commented on May 4, 2015

    @aballier
    aballier
    on May 4, 2015
    Author

    I'm already patching it locally to replace 'qmake-qt4' with 'qmake' and it seems to work perfectly. What I'm not sure is if this doesn't break other systems :/

  3. dirk-thomas
    added a commit that references this issue on May 4, 2015

    use qmake with QT_SELECT since qmake-qt4 is not available on all plat…

    315b3b1

  4. dirk-thomas commented on May 4, 2015

    @dirk-thomas
    dirk-thomas
    on May 4, 2015
    Contributor

    Related to a recent change: #13

    On ubuntu the dependency qt4-qmake depends on qtchooser which will bring in qmake. So it should be fine on Ubuntu. I have created PR #23 to address it.

    @bchretien Can you please double check that it still works for you with the PR applied?

  5. bchretien commented on May 5, 2015

    @bchretien
    bchretien
    on May 5, 2015
    $ qmake -v
QMake version 3.0
Using Qt version 5.4.1 in /usr/lib
$ QT_SELECT=4 qmake -v
QMake version 2.01a
Using Qt version 4.8.6 in /usr/lib

    Looks good to me.

  6. dirk-thomas
    closed this as completedin 315b3b1on May 5, 2015

  7. dirk-thomas commented on May 5, 2015

    @dirk-thomas
    dirk-thomas
    on May 5, 2015
    Contributor

    @bchretien Thank you for checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions