Skip to content

Refactor ros-ci-for-pr functions in preparation for PR stack support - #43

Open
christophebedard wants to merge 1 commit into
christophebedard/fix-pr-number-int-exceptfrom
christophebedard/ci-for-pr-refactors
Open

christophebedard wants to merge 1 commit into
christophebedard/fix-pr-number-int-exceptfrom
christophebedard/ci-for-pr-refactors

Conversation

@christophebedard

Copy link
Copy Markdown
Member
  • Extract parse_pull_spec() from validate_and_fetch_pull_list()
  • Extract prompt_continue_or_abort() from validate_pulls_target()
  • Add optional description_pulls parameter to create_ci_gist() to be able to list different PRs in the gist description
  • Add optional argv parameter to parse_args() to make it testable

Also add tests for these functions.

I used Claude Opus 5.5 to implement this.

* Extract `parse_pull_spec()` from `validate_and_fetch_pull_list()`
* Extract `prompt_continue_or_abort()` from `validate_pulls_target()`
* Add optional `description_pulls` parameter to `create_ci_gist()` to
  be able to list different PRs in the gist description
* Add optional `argv` parameter to `parse_args()` to make it testable

Also add tests for these functions.

Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant