Repository navigation
Refactor ros-ci-for-pr functions in preparation for PR stack support - #43
Open
christophebedard wants to merge 1 commit into
Open
christophebedard wants to merge 1 commit into
christophebedard wants to merge 1 commit into
Conversation
* Extract `parse_pull_spec()` from `validate_and_fetch_pull_list()` * Extract `prompt_continue_or_abort()` from `validate_pulls_target()` * Add optional `description_pulls` parameter to `create_ci_gist()` to be able to list different PRs in the gist description * Add optional `argv` parameter to `parse_args()` to make it testable Also add tests for these functions. Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_pull_spec()fromvalidate_and_fetch_pull_list()prompt_continue_or_abort()fromvalidate_pulls_target()description_pullsparameter tocreate_ci_gist()to be able to list different PRs in the gist descriptionargvparameter toparse_args()to make it testableAlso add tests for these functions.
I used Claude Opus 5.5 to implement this.