Repository navigation
Fix error message for non-numeric pull request numbers - #42
Open
christophebedard wants to merge 1 commit into
Open
christophebedard wants to merge 1 commit into
christophebedard wants to merge 1 commit into
Conversation
`int()` raises [`ValueError`](https://docs.python.org/3/builtins/exceptions.html#ValueError) when it gets a string that does not correspond to a number, not [`TypeError`](https://docs.python.org/3/builtins/exceptions.html#TypeError): ``` $ python3 -c "print(int('123'))" 123 $ python3 -c "print(int('1bc'))" Traceback (most recent call last): File "<string>", line 1, in <module> ValueError: invalid literal for int() with base 10: '1bc' ``` Therefore, the nice "isn't a number" error message was never printed. Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
int()raisesValueErrorwhen it gets a string that does not correspond to a number, notTypeError:Therefore, the nice "isn't a number" error message was never printed.
I used Claude Opus 5.5 to implement this. I verified that it was right about
ValueError(see above).