You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Bug] wallet recover / rebuild should not write keys to disk until all keys have been recovered. #407
Assume I have 9 minipools, 5 leb8s and then 1 leb8 which was a 0x00 solo validator i converted followed by 3 leb 8s from credit.
If I run rocketpool wallet recover or rocketpool wallet rebuild now, I believe the behavior will recover the first 5 keys, and then fail unless I've already imported my solo key.
Unfortunately, I'll have 5 out of 8 of the keys that I can recover in my wallet, which is a bit of a POLA violation.
Instead, smartnode should fail fully- if all keys can't be recovered, none are.
Additionally, it should have a new flag --allow-partial-recover or something that overrides this behavior, and recovers as many keys as it can (critically, after the failure, it should keep trying to recover subsequent keys).
Edit:
The response must inform the user which pubkeys were successfully recovered, and which were not, in the case of --allow-partial-recover.
If --allow-partial-recover is not passed, and recovery fails on iterating to the limit, we should ask the user if they did a solo migration and remind them that they must deal with the solo validator's keys manually, and keep them securely backed up, as they will not be recoverable by the node wallet's mnemonic.
Additionally, we should update rocketpool wallet test-recovery to be very verbose when recovery fails- which validators keys were successfully recovered, which failed to be recovered, which (if any) were imported from custom_keys. test-recovery should also take the opportunity, should it find any custom_keys, to provide a similar admonition about backing up the imported key.
Before we proceed, is this still something you want fixed on current Smartnode master, and is anyone already working on it? If not, would you be open to reviewing an external PR for it?
Activity
Crackdevs commentedon Sep 3, 2026
Hi @0xfornax @jshufro . We are looking at picking up #407 together with #572 for a Round 40 grant.
Before we proceed, is this still something you want fixed on current Smartnode master, and is anyone already working on it? If not, would you be open to reviewing an external PR for it?
0xfornax commentedon Sep 4, 2026
Hey @Crackdevs, yes we still want these implemented and I'm not aware of anyone currently working on it.