Repository navigation
Fixes and cleanup to list related keywords - #989
Merged
Merged
Conversation
Small changes to functionality too: - Get List Items optional argument renamed from `value` to `values`. This fixes robotframework#722. - List Selection Should Be doesn't anymore allow mixing labels and values. Possible backwards incompatible change. - Failure message from List Selection Should Be and List Should Have No Selection show both labels and values.
Earlier this caused an error. Fixes robotframework#977.
aaltat
approved these changes
Nov 7, 2017
| """Returns labels of selected options from selection list ``locator``. | ||
|
|
||
| Fails if there is no selection. | ||
| Starting from SeleniumLibrary 3.0, returns an empty list if there |
Contributor
There was a problem hiding this comment.
Should this chapter be last lines of the doc string? So that in future they are easy to spot and remove?
Member
Author
There was a problem hiding this comment.
In my opinion it's fine either way. It's anyway easy to find all references to SeleniumLibrary 3.0 and removing this note isn't hard either. The main reason I decided not to have the note at the end was that we'd end up with two very short paragraphs. If you want to change it, go ahead.
| """Returns values of selected options from selection list ``locator``. | ||
|
|
||
| Fails if there is no selection. | ||
| Starting from SeleniumLibrary 3.0, returns an empty list if there |
Contributor
There was a problem hiding this comment.
Should this chapter be last lines of the doc string? So that in future they are easy to spot and remove?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit messages of individual commits for more information.