Repository navigation
Add 'find_element(s)' to public API - #965
Merged
Merged
Conversation
We cannot promise that we keep these objects stable in the future. Better not to have them in the public API either. Related to robotframework#882.
aaltat
reviewed
Oct 22, 2017
| """ | ||
| return self._element_finder.find(locator, parent=parent) | ||
|
|
||
| def find_elements(self, locator, parent=None): |
Contributor
There was a problem hiding this comment.
Should this have similar sphinx style parameter definitions as find_element in above?
Member
Author
There was a problem hiding this comment.
It wouldn't hurt. More important change would be adding return type information, but it should mention that return type is a list of WebElement objects, not just that the type is a list.
Member
Author
There was a problem hiding this comment.
You had some other syntax changes to type info. Can you take care of all of them at the same time?
Contributor
There was a problem hiding this comment.
Yes I can. I will merge this PR and write separate PR for fixing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #882.
Also little cleanup to internal find_element(s) API.