Repository navigation
Generic library documentation update - #918
Merged
Merged
Conversation
Includes explaining the new `strategy:value` syntax (robotframework#908).
'implicit_wait' -> `implicit_wait`
aaltat
requested changes
Sep 25, 2017
|
|
||
| Examples: | ||
|
|
||
| | `Click Element` | name:foo | # Find element with class ``foo``. | |
Contributor
There was a problem hiding this comment.
I thin comment should say:
Find element with name attribute ``foo``
Member
Author
There was a problem hiding this comment.
Yeah, I changed the example but apparently forget the comment. Will fix.
| | `Click Element` | name:foo | # Find element with class ``foo``. | | ||
| | `Click Element` | default:name:foo | # Use default strategy with value ``class:foo``. | | ||
| | `Click Element` | //foo | # Find element using XPath ``//foo``. | | ||
| | `Click Element` | //foo | # Use default strategy with value ``//foo``. | |
Contributor
There was a problem hiding this comment.
The locator is same in the above xpath example but the comment says something else, should the locator be just foo without the double forward slashes.
Member
Author
There was a problem hiding this comment.
It should be default://foo. Will fix.
| used by all of them can be set globally using the | ||
| `Set Selenium Timeout` keyword. The same timeout also applies to | ||
| `Execute Async Javascript`. | ||
| used by all of them can be set globally using the `Set Selenium Timeout` |
Contributor
There was a problem hiding this comment.
Should we also say that timeout can be set in the library import?
Member
Author
There was a problem hiding this comment.
Good idea. Will add.
aaltat
approved these changes
Sep 25, 2017
Explain general topics in the general library documentation section, not in __init__.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes explaining the new
strategy:valuesyntax (#908).Still plan to update the documentation of the
__init__, but going through individual keywords is too much work for 3.0.