Skip to content

Get logs is very useful - #863

Merged
aaltat merged 13 commits into
robotframework:masterfrom
SergiuTudos:master
Aug 20, 2017
Merged

aaltat merged 13 commits into
robotframework:masterfrom
SergiuTudos:master

Conversation

@SergiuTudos

Copy link
Copy Markdown
Contributor

No description provided.

@aaltat

aaltat commented Aug 16, 2017

Copy link
Copy Markdown
Contributor

Please rebase with S2L master, resolve conflicts and push for review. Also please take a look at the new architecture, because many things has changed internally.

@aaltat

aaltat commented Aug 16, 2017

Copy link
Copy Markdown
Contributor

Code looks good in the mobile screen, but I need to take a second look from a bigger screen (I sometimes miss things from the small screen).

If the test pass and I don't find anything when looking on the bigger screen, then this can be merged to master and will be available for the next release.

@aaltat
aaltat merged commit 5b02d90 into robotframework:master Aug 20, 2017
@pekkaklarck

pekkaklarck commented Oct 12, 2017 •

Copy link
Copy Markdown
Member

On a closer look there were plenty of problems in this implementation. See #574 (comment) for more information.

I'm going to remove the current implementation but I hope we can include an enhanced version later. Are you @SergiuTudos interested to look at this again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants