Repository navigation
Fixes the changed Custom Locator API - #837
Merged
aaltat merged 2 commits intoJun 22, 2017
Merged
Conversation
Now the Custom Locator API uses the arguments:
${browser}, ${locator}, ${tag} and ${constraints}
Also moved usage of the CustomLocator to ElementFinder. And the
CustomLocator use the context for the browser.
This was referenced Jun 22, 2017
pekkaklarck
reviewed
Jun 22, 2017
| from selenium.webdriver.remote.webelement import WebElement | ||
|
|
||
| from Selenium2Library.base import ContextAware | ||
| from Selenium2Library.locators.customlocator import CustomLocator |
Member
There was a problem hiding this comment.
Should use from .locators import ... here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now the Custom Locator API uses the arguments:
${browser}, ${locator}, ${tag} and ${constraints}
Also moved usage of the CustomLocator to ElementFinder. And the
CustomLocator use the context for the browser.