Skip to content

Test with Python 3.6 instead of Python 3.3 - #792

Closed
cclauss wants to merge 17 commits into
robotframework:masterfrom
cclauss:patch-2
Closed

cclauss wants to merge 17 commits into
robotframework:masterfrom
cclauss:patch-2

Conversation

@cclauss

@cclauss cclauss commented Apr 11, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@cclauss

cclauss commented Apr 11, 2017

Copy link
Copy Markdown
Contributor Author

These changes solve several Python 3 issues but I can not determine how to fix the one failing test case: https://travis-ci.org/robotframework/Selenium2Library/jobs/220904266#L845

@HelioGuilherme66

Copy link
Copy Markdown
Member

Please change your Git strategy. I recommend for you to:

  1. Set up your own Travis builder (it's free)
  2. Close this PR, and resubmit after doing all the testing and Squashing!

@cclauss

cclauss commented Apr 11, 2017 •

Copy link
Copy Markdown
Contributor Author

Agreed. The last successful build on this repo was your Travis 816 build 3 months ago.

@cclauss cclauss closed this Apr 11, 2017
@cclauss
cclauss deleted the patch-2 branch April 11, 2017 12:39
@aaltat

aaltat commented Apr 11, 2017

Copy link
Copy Markdown
Contributor

Thank you for the effort. But it might have been good idea to discuss​about the problem first. We, here means maintainers, might have an opinion how that should have been fixed.

@pekkaklarck

Copy link
Copy Markdown
Member

Notice also that Python 3 efforts, and any other larger change, should wait for the new architecture that is currently under review and finalization. See #770 for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants