[just-be-dev]

This may or may not be merged.

@emanlove, we briefly discussed this in #356 and I just wanted to broach the issue again. It was raised in #469 that the documentation using Get WebElements was wrong. I've corrected it in #472, but I'm using Get WebElement which obviously doesn't exist.

We could of course just correct the documentation and only keep Get WebElements.

It would be this

@{elements}=   Get WebElements  id=my_element
Click Element  @{elements}[0]

versus

${element}=  Get WebElement  id=my_element
Click Element  ${element}

@pekkaklarck, feel free to jump in on this conversation too.

[emanlove]

Do we want to do this or follow along with what the other find element keywords do? Something like ...

        return self._element_find(locator, True, True)

where we set the first_only flag to True. I like this a little better if only for the reason that it follows what other find elements are doing and if this changing in the future Get WebElement will do the same thing.

[just-be-dev]

I forgot and left these logs in here.

We should take those out.

[just-be-dev]

I'll update this to remove the log statements in the test and I suppose we should add to the changelog as well.

Anything else to add @emanlove?

[emanlove]

@zephraph Did you remove the logs? Looks like there are still there...

[just-be-dev]

I haven't even submitted another commit yet. You can go ahead and do it if you'd like.

[emanlove]

Done

[just-be-dev]

Sorry, that commit didn't work right.

I was in the middle of committing the same time you did, so I pulled but it ended up doing something wanky.

[just-be-dev]

Regardless, I think this is good to go. Do you want to look over it? I'll let you merge when you feel it's ready.