Repository navigation
Enhance select window - #407
Conversation
|
Hey @zephraph , I have done this PR and passed all my testing. Please review for merge. |
There was a problem hiding this comment.
So, I might be missing something. If they provide a locator, couldn't this possible return the wrong window?
|
@emanlove, @pekkaklarck, @ombre42 Can any of you assist in this review? |
|
actually the 'return self._current_browser().get_current_window_handle()' is making a result and store it only. after try block the finally block will be executed, at last the function ends and the stored return value is pop up to caller. |
|
Overall it looks good to me, but I want to give it another day or two to let someone else look at it before I merge. |
|
Hey @divfor, I'm sorry this is taking so long. Being as we haven't heard from anyone else, I'll take some extra time tonight and play around with this until I'm comfortable that I understand exactly everything you're doing. If I can't break it then I'll merge it tomorrow. |
|
Thank you, zephraph. |
|
Hey @divfor, I'm planning on releasing 1.7 today. Do you want this in that release, or is it okay to wait for 1.7.1? If you want it in today, please merge with master as soon as you're able. Thanks! |
|
I tried but can not fix the conflicts in CHANGES.rst... |
|
So we're you able to get it? I can do a PR on your fork if you need. |
|
Tell me when you're done making changes and I'll open a PR on your branch to do the merge. |
|
I still cannot fix the conflicts. please start from the latest 'Update CHANGES.rst' -- aa50ade. |
Enhance select window
|
Hopefully this builds successfully! I'm really ready to push out this release... |
There was a problem hiding this comment.
Wouldn't it be better to only switch to the window when you know that it meets the right criteria? If it's unable to locate the handle you want to switch to, I would think the expected behavior would be to stay on the current handle.
|
Yes, we can add it like what _select_matching() does. |
this is a re-submit for PR #395 - rebase to latest rotmac/master to resolve conflict