Skip to content

Add 'Wait Until Page Not Contains Element' -keyword - #375

Merged
just-be-dev merged 5 commits into
robotframework:masterfrom
molsky:wait_until_page_not_contains_element2
May 6, 2015
Merged

just-be-dev merged 5 commits into
robotframework:masterfrom
molsky:wait_until_page_not_contains_element2

Conversation

@molsky

@molsky molsky commented Apr 13, 2015

Copy link
Copy Markdown
Contributor

I hope that this is implemented in proper way.

@molsky molsky changed the title Add 'Wait Until Page Not Contains' -keyword Add 'Wait Until Page Not Contains Element' -keyword Apr 13, 2015
@molsky

molsky commented Apr 13, 2015

Copy link
Copy Markdown
Contributor Author

Well of course I managed to typo my commit message so now it is misleading Wait Until Page Not Contains Element (that was actually implemented in this commit) vs Wait Until Page Not Contains.

Edit:
Amended commit and then force pushed it again.

@just-be-dev

Copy link
Copy Markdown
Contributor

This should probably be Wait Until Page Does Not Contain Element. It's more verbose, but more proper.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be Wait Until Page Contains Element?

@molsky

molsky commented Apr 15, 2015

Copy link
Copy Markdown
Contributor Author

I used the following ticket as a reference for missing keywords:
#246
The keyword name Wait Until Page Not Contains Element was taken from that list.
I think this needs others opinion should keyword's name be changed from Not Contains to Does Not Contain format.

@just-be-dev

Copy link
Copy Markdown
Contributor

@emanlove, what do you think on the wording?

@emanlove

emanlove commented May 1, 2015

Copy link
Copy Markdown
Member

@zephraph We had a discussion about wording a while back. It centred around the idea that the java port of the Selenium2Library had some keywords that weren't yet within this library. As some got added we tended toward using the same keyword name. But for some of them they we too grammatically incorrect.

Personally I think it should be ...Does Not Contain... Looking to see if I can find that discussion...

@molsky

molsky commented May 4, 2015

Copy link
Copy Markdown
Contributor Author

Trying to do the changes to the keyword name within a few days. I agree with you that Does Not Contain makes more sense than Not Contains.

@just-be-dev

Copy link
Copy Markdown
Contributor

@molsky, Once you rebase and make those changes I'll merge this for you. If you need help rebasing let me know. Thanks for contributing!

@molsky

molsky commented May 6, 2015

Copy link
Copy Markdown
Contributor Author

Changes done and I hope that I did rebasing and pushing changes in correct way.

@just-be-dev

Copy link
Copy Markdown
Contributor

Awesome job! Thanks for contributing. =]

just-be-dev added a commit that referenced this pull request May 6, 2015
…ent2

Add 'Wait Until Page Does Not Contain Element' keyword
@just-be-dev
just-be-dev merged commit e85fcd7 into robotframework:master May 6, 2015
@EricZeff EricZeff mentioned this pull request May 11, 2015
4 of 20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants