Skip to content

Make renderExtractedLinks test helper use extractLinks again - #52

Open
mikehartley wants to merge 1 commit into
robinst:mainfrom
mikehartley:fix-render-extracted-links-helper
Open

mikehartley wants to merge 1 commit into
robinst:mainfrom
mikehartley:fix-render-extracted-links-helper

Conversation

@mikehartley

Copy link
Copy Markdown

Since 2a59d40 ("Use non-deprecated API for tests") the helper iterated extractSpans, making it identical to renderExtractedSpans.

Since 2a59d40 ("Use non-deprecated API for tests") the helper iterated
extractSpans, making it identical to renderExtractedSpans. The URL, WWW
and email tests therefore checked extractSpans twice and never ran their
inputs through extractLinks.

Build the output from extractLinks directly, without going back to the
deprecated Autolink.renderLinks.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant