Repository navigation
Make renderExtractedLinks test helper use extractLinks again - #52
Open
mikehartley wants to merge 1 commit into
Open
mikehartley wants to merge 1 commit into
mikehartley wants to merge 1 commit into
Conversation
Since 2a59d40 ("Use non-deprecated API for tests") the helper iterated extractSpans, making it identical to renderExtractedSpans. The URL, WWW and email tests therefore checked extractSpans twice and never ran their inputs through extractLinks. Build the output from extractLinks directly, without going back to the deprecated Autolink.renderLinks.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 2a59d40 ("Use non-deprecated API for tests") the helper iterated extractSpans, making it identical to renderExtractedSpans.