Conversation
Just for fun and to see how well it works.
bgentry
approved these changes
Oct 4, 2026
| run: make test/race | ||
|
|
||
| build_and_test_pgrust: | ||
| name: Test pgRust (latest) |
Contributor
There was a problem hiding this comment.
Might want to rename this or else rename the others—as of now in the checks UI this one is the odd one out.
Comment on lines
+23
to
+27
| container_id=$(docker run --detach --pull always \ | ||
| --publish 127.0.0.1::5432 \ | ||
| --env POSTGRES_PASSWORD=postgres \ | ||
| --env POSTGRES_DB=river_test \ | ||
| malisper/pgrust:latest) |
Contributor
There was a problem hiding this comment.
Is this the right / efficient way to do this, as opposed to declaring the docker-based service as part of the GHA workflow? Asking because there may be benefits in caching/speed/etc calling Docker there vs in a script. I haven't researched it though.
bgentry
added this pull request to stack #1428
October 4, 2026 18:50
Contributor
Author
|
Good questions. I'm going to leave this one in draft form to mull it over a bit. It's kinda cool but probably not needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just for fun and to see how well it works.