Repository navigation
Stringify: allow empty string for indent option - #151
Conversation
|
@SlexAxton Apologies for the ping, but I think you will find this bugfix PR limited in scope, with non-breaking changes and newly added tests to confirm the proper behavior. I would appreciate it if you could review it. |
|
@tj Apologies for the ping, but I think you will find this bugfix PR limited in scope, with non-breaking changes and newly added tests to confirm the proper behavior. I would appreciate it if you could review it. |
|
Has anyone taken a look at this PR? I got here from the issue in |
|
@SlexAxton Thank you for merging the PR. Could you make an npm release including the fix so I can complete the PR that depends on this in jest-styled-components? |
|
Ha, well well...I came here after taking the same journey as @fritz-c tracking down why my diffs in Which is to say: seconded, is it possible to get a 3.0.1 release with just this change? |
|
Is anyone still interested in a 3.0.1 ? |
In the existing implementation, empty strings used in the indent option are treated as falsy and therefore ignored in the following fallback:
css/lib/stringify/identity.js
Line 253 in b7f3cb6
This PR resolves that issue, and adds tests for behavior surrounding the indent option.