Reconsider storing constructors internally #77

Activity

1. simonepri commented on Aug 16, 2017

   

   simonepri

   on Aug 16, 2017

   Last edited by simonepri

   More actions

   Maybe we could add something like an optional 'namespace' while creating a new Constructor?
   For me it makes sense to leave users the handling of custom error constructors. Maybe we could move that feature to an external package to reduce the friction.

   Talking about usability we should also rethink themakeErrFromCode function.
   The absence of the new keyword makes the error creation incoherent and may generate confusions.

   The syntax should be something like:

   new errors.HttpCode(httpCode, /* Any argument combination available for other errors constructors */);
   

   or something like that:

   const Err = errors.errFromCode(code);
   new Err(/* arguments */);
   // or shorter:
   new errors.errFromCode(code)(/* arguments */);
   
2. DonutEspresso commented on Feb 22, 2018

   

   DonutEspresso

   on Feb 22, 2018

   MemberAuthor

   More actions

   As suggested in this thread, custom error constructors are now returned directly to end user. This is effective starting in 6.x.
3. DonutEspresso

   closed this as completedon Feb 22, 2018