Repository navigation
Accept additive HTTP JSON fields and add strict config decoding - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Older Rust and Dart clients reject additive API response fields when a schema declares
additionalProperties: false. A new podcast directory URL can therefore prevent an installed desktop client from loading any podcasts.Default JSON models to accepting extra object fields, and add
--strictfor configuration decoding across Go, Rust, TypeScript, and Dart. Strict mode honors closed objects through nested models, arrays, and tagged payloads while preserving explicitly open metadata. TypeScript also supports--mode typesand exports runtime config decoders; strict HTTP clients validate ordinary JSON responses. Install Dart in CI for the generated-runtime contract checks.Validation:
unknown field apple_podcasts_urlwith an older generated Rust HTTP client before the fix; the regression now passes.moon run oasmith:test-rust: 8 passed, including required-field, type, and discriminator failures.moon run oasmith:test: passed, including generated Go and Dart JSON policy checks.moon run oasmith:lint: passed.This controls unknown-field handling; it is not full JSON Schema validation.