Repository navigation
closed-loop-report: apply bridge-3.4 start_frame in the idx check - #278
Merged
1 commit merged intoOct 28, 2026
Merged
1 commit merged into
1 commit merged into
Conversation
Since Studio v0.91 / bridge 3.4 every startClosedLoop config carries start_frame, and the bridge sets offset = (start_frame mod frames) x deg_per_frame for that message. The logged browser config still says offset: 0 and the bridge's "[cfg] applied" line goes to stderr only, so the report predicted every start_frame epoch from frame 0 and flagged 100 % idx mismatch (ww18 2026-10-27, bench_closed_loop_2x10.yaml). The report now replays the config echoes in order the way bridge.py's handler does (apply_config): offset from the message, overridden by start_frame using the same message's pitch and frame count, cleared by the next message's offset (one-shot). Logs without start_frame are unchanged. The table shows "frames @start" and the legend names it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 27, 2026
Merged
taylorlm88
pushed a commit
to taylorlm88/webDisplayTools
that referenced
this pull request
Nov 6, 2026
… in the idx check
taylorlm88
pushed a commit
to taylorlm88/webDisplayTools
that referenced
this pull request
Nov 6, 2026
Candidate for Production. PRs: reiserlab#274, reiserlab#278, reiserlab#273. Release-Manifest: releases/2026-10-27.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found during the LAB-338 extraction QC on ww18 (2026-10-27); the report script is also what the
start_frameruns of LAB-303 rigs are judged with.scripts/closed-loop-report.pypredicted every closed-loop row asround((coupling·Δheading + offset + bias)/deg_per_frame) mod frames, takingoffsetfrom thebrowser's
configecho. Since Studio v0.91 / bridge 3.4, eachstartClosedLoopconfig also carriesstart_frame. For that message the bridge setsoffset = (start_frame mod frames) × deg_per_frame,but the logged browser config still says
offset: 0. The result was 100 % idx mismatch onevery epoch that opens off frame 0.
The bridge's
[cfg] applied …line goes only to stderr, and the ROS node uses the samemake_dispatcher. Neither log records the offset the bridge actually applied, so the reportreplays the config echoes in order, the way
bridge.pyhandles them (apply_config):offsetis applied first;start_framethen overrides it, using the same message'sdeg_per_frameandframes(taken mod frames, likePipeline.start_frame_to_offset);offsetreplaces it (one-shot: the stopClosedLoop push resets it to 0);start_frame(≤ 3.3) give the same results as before.The epoch JSON gains
start_frameandoffset_deg. In the markdown table the frames column nowreads
200 @25, and the legend explains the start_frame offset.docs/development/closed-loop-bias.md(the offline reconstruction recipe) now describes the same rule.
Evidence: two runs of
protocols/validation/bench_closed_loop_2x10.yamlon reiserlab-ww18(2026-10-27, bridge 3.4; epochs open on frames 25 and 75). Before this change: 100 % / 100 % on both runs.
After: 0.00 % on all 4 epochs.
Tier
next candidate
Release notes
none
Test plan
pixi run test: 72/72 files passed (Windows)tests/test-fictrac-sim.pynew "start_frame (bridge 3.4)" block:apply_configmatchesbridge.Pipeline.start_frame_to_offset, including mod frames200 @25/200 @75andstart_frameappear in the markdown🤖 Generated with Claude Code