Skip to content

Rename ros2-poc/ → rig/ and arena_interfaces → rig_interfaces (LAB-303 cleanup, no behavior change) - #270

Merged
4 commits merged into
mainfrom
claude/rename-ros2-poc-rig
Oct 26, 2026
Merged

4 commits merged into
mainfrom
claude/rename-ros2-poc-rig

Conversation

@mbreiser

@mbreiser mbreiser commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Why

The decision record docs/development/rig-software-repos-and-runners.md (§3.2, §7.12) renames the ROS 2 workspace ros2-poc/ → rig/ and its interfaces package arena_interfaces → rig_interfaces ahead of the rig-nodes extraction. Under rmw_zenoh the message type name is part of the wire key and of every recorded MCAP bag's schema (rig_interfaces/msg/ArenaFrame), so the rename has to land now, before any released bag carries the typed names; the PoC bags on Dropbox stay readable under the old name. Mechanical rename only, no behavior change.

What

  • git mv ros2-poc rig; interfaces/arena_interfaces → interfaces/rig_interfaces; .github/workflows/arena-interfaces.yml → rig-interfaces.yml (workflow name, path filters, working-directory: rig, artifact names rig_interfaces-<subdir>, channel artifact rig-interfaces-channel, tag trigger rig-interfaces-v*, repository variable RIG_INTERFACES_CHANNEL, concurrency group).
  • Package renamed in package.xml, CMakeLists.txt, the package pixi.toml and the workspace pixi.toml (path dependency, workspace name rig); version bumped 0.1.0 → 0.2.0 in package.xml and the package pixi.toml (a renamed package is a new package; the decision note's release recipe bumps on any change). Message type names ArenaFrame / FicTracFrame / ConnectorReply are unchanged.
  • Every import, type string (rig_interfaces/msg/ArenaFrame, …/FicTracFrame), startswith("rig_interfaces/") check, librig_interfaces__* glob and PKG path in rig/nodes/*.py and rig/tests/test_ros2_poc.py; the paths in CLAUDE.md, the g6-orientation skill, js/plugin-registry.js (comment), js/arena-runner-g6.js (error string rig bridge node), the two test version strings ('3.4 · rig'), and the docs that name the current path. The decision record is touched only where it names the current path (section 9 untouched). The test file test_ros2_poc.py keeps its name (the pixi test task references it).
  • Records (windows-results-ww18-2026-10-15.md, scanimage-day-2026-10-16.md, docs/typed-windows.md, the explainer HTML, channel/README.md history) keep their historical names and filenames and carry one italic note about the rename.
  • typed-prebuilt, in three commits (the 30512581 → 2026-10-18 precedent): (1) the old pin (commit 30512581, ros2-poc/channel, win-64) holds arena_interfaces 0.1.0, which code importing rig_interfaces must never install — feature and environment commented out; (2) payload commit 39eeb1fa: the rig-interfaces-channel artifact of the green run 40401906061 (built from eb2bf01) committed under rig/channel/ (win-64, osx-arm64, linux-64, noarch; channel/README.md lists files, sha256s, mutex pins); (3) typed-prebuilt re-enabled for all three platforms, pinned to https://raw.githubusercontent.com/reiserlab/webDisplayTools/39eeb1fa43874aae7d845dfec2a8f049c68f8954/rig/channel, payload removed from the tree again. The rig-interfaces-v0.2.0 tag is pending — Michael's call.
  • Note on the CI packages: each runner's pixi-build-ros backend resolved its own RoboStack Jazzy, so the packages pin ros2-distro-mutex >=0.20,<0.21 + Python 3.14 on win-64 / linux-64 and >=0.16,<0.17 + Python 3.12 on osx-arm64 — not the 0.19 the poc solve group locks. typed-prebuilt is its own solve group, so it resolves that set per platform (recorded in channel/README.md); the default / typed / viz environments are untouched.
  • rig/pixi.lock: first commit hand-edited (three conda_source records renamed, the old typed-prebuilt environment and its one package record dropped) because a pixi lock re-solve on the Mac (pixi 0.69) upgraded all of RoboStack (build 25 → 27, Python 3.12 → 3.14), which a rename must not do; the final commit's pixi lock solved only the prebuilt group (the poc group's records are unchanged; pixi 0.69 drops the virtual-packages blocks pixi 0.80 wrote and one orphaned win-64 libharfbuzz-devel record of the old prebuilt env).
  • Confirmed: no ros2-poc reference in scripts/tiers/*.py, .github/workflows/deploy-pages.yml, the root pixi.toml or .gitignore.

Tier

next candidate (cleanup after 2026-10-20)

Release notes

none

Test plan

  • pixi run test at the repo root: 71/71 files passed
  • pixi run format-check: the touched JS files pass (the three pre-existing warnings on main are untouched files)
  • cd rig && pixi install --locked (default env) accepts the hand-edited lock
  • cd rig && pixi run test (whole-graph harness, default env): 55/55 PASS, exit 0 (a first run overlapped another worktree's graph on the shared Zenoh router and showed doubled connector replies; re-run clean)
  • cd rig && pixi run rig -- --help
  • cd rig && pixi install --locked -e typed builds rig_interfaces-0.2.0-h60d57d3_0.conda (17 s); pixi run -e typed test: 57/57 PASS, bag schemas rig_interfaces/msg/ArenaFrame, rig_interfaces/msg/FicTracFrame, std_msgs/msg/String; ArenaFrame values decode from the bag's own schema
  • rig-interfaces workflow on eb2bf01: build (win-64 / osx-arm64 / linux-64) + channel (index + artifact) all green
  • cd rig && pixi install --locked -e typed-prebuilt on osx-arm64 resolves the pinned channel; from rig_interfaces.msg import ArenaFrame, FicTracFrame, ConnectorReply imports (Python 3.12.16)
  • CI on the final head (test, tiers, validate; the rig-interfaces workflow does not re-run — the final commits touch neither rig/interfaces/** nor the workflow)

Linear: LAB-303

🤖 Generated with Claude Code

mbreiser and others added 4 commits October 26, 2026 17:08
…3 cleanup, no behavior change)

Decision record docs/development/rig-software-repos-and-runners.md §3.2 / §7.12. Under
rmw_zenoh the message type name is part of the wire key and of every recorded bag's
schema, so the package is renamed before any released bag carries the typed names.

- git mv ros2-poc → rig; interfaces/arena_interfaces → interfaces/rig_interfaces;
  .github/workflows/arena-interfaces.yml → rig-interfaces.yml (name, path filters,
  working-directory, artifact/channel names, tag trigger rig-interfaces-v*, repository
  variable RIG_INTERFACES_CHANNEL, concurrency group).
- Package renamed in package.xml, CMakeLists.txt, the package pixi.toml and the workspace
  pixi.toml (path dep, workspace name "rig"); version bumped 0.1.0 → 0.2.0 (a renamed
  package is a new package). Message type names ArenaFrame / FicTracFrame / ConnectorReply
  are unchanged; only the package changes.
- Every import / type string / typesupport glob in rig/nodes and rig/tests, every path in
  CLAUDE.md, the g6-orientation skill, js/ comments and strings, the two test version
  strings ('3.4 · rig'), and the docs that name the current path.
- Records (ww18 results, ScanImage day, typed-windows, the explainer HTML, channel/README)
  keep their historical names and carry one italic note about the rename.
- typed-prebuilt: the old pin (commit 3051258, ros2-poc/channel) holds arena_interfaces
  0.1.0 (win-64), which code importing rig_interfaces must never install; the feature and
  environment are commented out with a TODO(rename) until the CI-built rig_interfaces 0.2.0
  channel is committed (next commits of this PR).
- pixi.lock: hand-edited (three conda_source records renamed, the typed-prebuilt
  environment and its one raw.githubusercontent.com package record dropped) — a `pixi lock`
  re-solve on this Mac upgraded all of RoboStack (build 25 → 27, Python 3.12 → 3.14), which
  a mechanical rename must not do. `pixi install --locked` accepts the edited lock.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…; the next commit pins it and removes the payload from the tree)

Artifact rig-interfaces-channel of workflow run 40401906061 (commit eb2bf01): win-64,
osx-arm64, linux-64 + an empty noarch, indexed by rattler-index. channel/README.md records
the files, sha256s and ros2-distro-mutex pins. The two channel/ ignore lines are lifted
for this one commit.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…pinned to 39eeb1f); payload removed from the tree

The feature and environment come back for win-64, osx-arm64 and linux-64, pinned to
https://raw.githubusercontent.com/reiserlab/webDisplayTools/39eeb1fa43874aae7d845dfec2a8f049c68f8954/rig/channel
(the payload commit); the four channel/<subdir>/ directories leave the tree again
(`git rm --cached`, ignore lines restored and extended), exactly the 3051258 → 2026-10-18
precedent. pixi.lock: `pixi lock` solved only the prebuilt group (its own solve group); the
poc group's records are unchanged (the diff's moved lines re-sort; dropped: the
virtual-packages blocks pixi 0.69 does not write, one orphaned win-64 libharfbuzz-devel
record of the old prebuilt env). The CI packages pin the RoboStack mutex their runner
resolved (win-64 / linux-64: 0.20, Python 3.14; osx-arm64: 0.16, Python 3.12), so the
prebuilt group resolves that set per platform, not the poc group's 0.19 (channel/README.md).
Verified on osx-arm64: `pixi install --locked -e typed-prebuilt` + import of
rig_interfaces.msg.{ArenaFrame,FicTracFrame,ConnectorReply}.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
… (what the extraction session inherits)

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@mbreiser mbreiser closed this pull request by merging all changes into main in 71c7a60 Oct 26, 2026
@mbreiser
mbreiser deleted the claude/rename-ros2-poc-rig branch October 26, 2026 23:03
taylorlm88 pushed a commit to taylorlm88/webDisplayTools that referenced this pull request Nov 6, 2026
…ig_interfaces (LAB-303 cleanup, no behavior change)

# Conflicts:
#	rig/README.md
#	rig/nodes/bridge_node.py
#	rig/nodes/mcap_convert.py
#	rig/pixi.toml
#	rig/sizing/columns.py
#	rig/tests/test_ros2_poc.py
taylorlm88 pushed a commit to taylorlm88/webDisplayTools that referenced this pull request Nov 6, 2026
Candidate for Production. PRs: reiserlab#264, reiserlab#219, reiserlab#270.

Release-Manifest: releases/2026-10-26.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant