Repository navigation
fictrac: drop start/stopRecording (recording isn't a real command) - #136
Merged
Merged
Conversation
The fictrac plugin's start/stopRecording were cosmetic — they mapped to a log-marker op, but the bridge logs every FicTrac frame continuously once connected, so recording was never a per-trial capability. Remove them, leaving the two load-bearing pairs: connect/disconnect (bridge lifecycle) and startClosedLoop/stopClosedLoop (drive the arena). Open-loop trials just run the arena's own commands with no fictrac call. Camera's start/stopRecording (BIAS) is unaffected. If windowed recording is ever wanted it becomes real in the logging redesign (LAB-144). - js/plugin-registry.js: fictrac commands = connect/disconnect + start/stopClosedLoop - js/arena-runner-g6.js: drop the fictracMark op + its mapping (removed cmd -> skip) - tests/fixtures/v3_fictrac_closed_loop.yaml: open_loop is now trialParams(mode 2)+wait - tests/test-arena-runner-g6.js: assert removed startRecording -> skip Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #131. The
fictracplugin'sstartRecording/stopRecordingwere cosmetic — they mapped to a log-marker op (fictracMark → bridge.log), but the bridge logs every FicTrac frame continuously the moment it's connected, so "recording" was never a real per-trial capability.Removing them leaves the two load-bearing command pairs:
connect/disconnect— bridge WebSocket lifecyclestartClosedLoop/stopClosedLoop— the only thing that changes arena behavior (drive from FicTrac, Mode-3)Open-loop trials just run the arena's own commands with no fictrac call — FicTrac is still recorded in parallel by the bridge.
Changes
js/plugin-registry.js— fictrac commands are now exactly connect/disconnect + start/stopClosedLoop.js/arena-runner-g6.js— dropped thefictracMarkop + its mapping; a removed fictrac command now falls through to skip.tests/fixtures/v3_fictrac_closed_loop.yaml—open_loop_gratingis nowtrialParams(Mode 2) +wait, no annotation.tests/test-arena-runner-g6.js— asserts the removedstartRecording→ skip.Not touched: the
camera(BIAS) plugin'sstartRecording/stopRecording— those are real and used across the other fixtures.Verified
pixi run testgreen (plugin-registry, arena-runner, v3-roundtrip suites confirmed on this base); Prettier clean.open_loop_grating: [trialParams, wait]with no fictrac command.If windowed recording (separate from driving) is ever wanted, it becomes a real feature in the logging redesign — LAB-144.
🤖 Generated with Claude Code