Skip to content

fictrac: drop start/stopRecording (recording isn't a real command) - #136

Merged
mbreiser merged 1 commit into
mainfrom
fix/fictrac-drop-recording
Jul 2, 2026
Merged

mbreiser merged 1 commit into
mainfrom
fix/fictrac-drop-recording

Conversation

@mbreiser

@mbreiser mbreiser commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #131. The fictrac plugin's startRecording/stopRecording were cosmetic — they mapped to a log-marker op (fictracMark → bridge.log), but the bridge logs every FicTrac frame continuously the moment it's connected, so "recording" was never a real per-trial capability.

Removing them leaves the two load-bearing command pairs:

  • connect / disconnect — bridge WebSocket lifecycle
  • startClosedLoop / stopClosedLoop — the only thing that changes arena behavior (drive from FicTrac, Mode-3)

Open-loop trials just run the arena's own commands with no fictrac call — FicTrac is still recorded in parallel by the bridge.

Changes

  • js/plugin-registry.js — fictrac commands are now exactly connect/disconnect + start/stopClosedLoop.
  • js/arena-runner-g6.js — dropped the fictracMark op + its mapping; a removed fictrac command now falls through to skip.
  • tests/fixtures/v3_fictrac_closed_loop.yaml — open_loop_grating is now trialParams (Mode 2) + wait, no annotation.
  • tests/test-arena-runner-g6.js — asserts the removed startRecording → skip.

Not touched: the camera (BIAS) plugin's startRecording/stopRecording — those are real and used across the other fixtures.

Verified

  • pixi run test green (plugin-registry, arena-runner, v3-roundtrip suites confirmed on this base); Prettier clean.
  • Fixture parses to open_loop_grating: [trialParams, wait] with no fictrac command.

If windowed recording (separate from driving) is ever wanted, it becomes a real feature in the logging redesign — LAB-144.

🤖 Generated with Claude Code

The fictrac plugin's start/stopRecording were cosmetic — they mapped to a
log-marker op, but the bridge logs every FicTrac frame continuously once
connected, so recording was never a per-trial capability. Remove them, leaving
the two load-bearing pairs: connect/disconnect (bridge lifecycle) and
startClosedLoop/stopClosedLoop (drive the arena). Open-loop trials just run the
arena's own commands with no fictrac call. Camera's start/stopRecording (BIAS)
is unaffected. If windowed recording is ever wanted it becomes real in the
logging redesign (LAB-144).

- js/plugin-registry.js: fictrac commands = connect/disconnect + start/stopClosedLoop
- js/arena-runner-g6.js: drop the fictracMark op + its mapping (removed cmd -> skip)
- tests/fixtures/v3_fictrac_closed_loop.yaml: open_loop is now trialParams(mode 2)+wait
- tests/test-arena-runner-g6.js: assert removed startRecording -> skip

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@mbreiser
mbreiser merged commit bec5a1b into main Jul 2, 2026
3 checks passed
@mbreiser
mbreiser deleted the fix/fictrac-drop-recording branch September 28, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant