Repository navigation
upgrade three.js and node (for testing) - #1
Merged
Merged
Conversation
floesche
commented
Jan 23, 2026
Member
- three.js: r128 (2021) → r182 (2025)
- node.js: v20 (maintenance LTS from 2023) → v24 (active LTS from 2025)
- three.js: r128 (2021) → r182 (2025) - node.js: v20 (maintenance LTS from 2023) → v24 (active LTS from 2025)
mbreiser
pushed a commit
that referenced
this pull request
Jan 24, 2026
Update both validation workflows to use Node.js v24 (active LTS) for consistency. This aligns with PR #1's upgrade and ensures all CI/CD tests run on the same Node.js version. - validate-calculations.yml: v20 → v24 - validate-g6-encoding.yml: v20 → v24
mbreiser
added a commit
that referenced
this pull request
Oct 27, 2026
…d on the installed rig_nodes package (LAB-303, LAB-338) The shared half of rig/ moved to reiserlab/rig-nodes (PR #274); this merge re-expresses the okey-cokey additions through the installed package instead of the deleted local modules: * rig.py — the --no-fictrac / --stimulus / --stimulus-args options and the stimulus Child on top of the rig_nodes.supervise composition (fictrac via `python -m rig_nodes.fictrac_udp_adapter` only when not --no-fictrac; the udp 60000 preflight skipped the same way). * foxglove_json.py — the arena wrapper around rig_nodes.foxglove_json.convert keeps #274's `enrich` hook (frame derivations, FicTrac columns) and adds the --stimulus dashboard replay as the rewriter's `derive` hook (whole-stream → new topics, foxglove.CompressedImage by well-known schema name); dashboard_replay.run_streams is unchanged. Needs rig-nodes PR #1 (derive hook). * bias_health.py — moved to rig-nodes (rig_nodes.bias_health, rig-nodes PR #1); viz_node.py, dashboard_replay.py and the tests import it from there, test_stimulus's bias_health section moved with it (tests/test_pure.py in rig-nodes). * viz_node.py / stimulus_node.py / test_stimulus_live.py — `_common` → `rig_nodes._common`, the launcher primitives → `rig_nodes.supervise`. Until the next rig-nodes package set ships, run with `cd rig && pixi install -e dev` (a sibling ../../rig-nodes checkout on feat/bias-health or later) — the released 0.2.1 has no bias_health / derive. Tests (dev env): test-stimulus 50/50, test-viz, `pixi run test`; root `pixi run test` 72/72. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Merged
6 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.