Skip to content

fix(clojure): don't crash if there's no postData content - #171

Merged
erunion merged 1 commit into
mainfrom
fix/clojure-crash
May 25, 2023
Merged

erunion merged 1 commit into
mainfrom
fix/clojure-crash

Conversation

@erunion

@erunion erunion commented May 25, 2023

Copy link
Copy Markdown
Member

No description provided.

@erunion erunion added the bug Something isn't working label May 25, 2023
@erunion
erunion merged commit 4478658 into main May 25, 2023
@erunion
erunion deleted the fix/clojure-crash branch May 25, 2023 22:37
erunion added a commit that referenced this pull request Jun 23, 2023
* feat: suppert restsharp 107+

Updates restsharp support following their breaking
changes, reported in Kong#312

* add 'using RestSharp'

* update fixtures

* add write response.content at end

* fix(clojure): don't crash if there's no postData content (#171)

* ci: extend ci testing to run on node 20

* build: 5.1.1 release

* feat: dropping support for node 14

* chore(deps): bumping out of date deps

* build: 6.0.0 release

* wip

* getting the csharp integration tests running

* if NODE_ENV=test, these no longer run

* better csharp dockerfile

* the postdata-malformed fixture shouldn't expect a content-type header

* hammering the int tests into shape

* add httpbin

* wip (see below for details)

- go-httpbin is using my local tag bc of mccutchen/go-httpbin#123
- go-httpbin incorrectly thinks our requests are coming in on plain http. Possibly https://stackoverflow.com/a/61446922 is the answer?
- getting close

* updating fixtures for different bin

* wip

* 17 of 18 shell tests passing

* add a reverse proxy so 80 and 443 both go to httpbin

* remove console

* update python output

.json() will parse the output _out_ of json and print it
as a python object, which our integration tests cannot
then parse

* more dockerfile updating

* tell requests to use our CA

* fix python whoopsie

* php tests pass

* tell node to use system ca certs

* update node dockerfile

* switch back to mccutchen

* format integration_test.sh

* fix WORKDIR order in node dockerfile

* remove logging

* now the node tests pass locally

* try adding a node install

I'm not sure why it builds locally but not on gh

* Revert "now the node tests pass locally"

- This broke a lot of other tests

This reverts commit 0d6670d.

* ah HA found it

* remove unnecessary volumes

* add comment

* remove merge artifact

* update csharp dockerfile

* integration test fixes + comments

* fix csharp content type and add newline at end

* fix postdata-malformed fixture

* add explicit json header

* get final tests to pass

* remove cli arg because I can't figure out how to update the snapshots

* fix content-type condition

* don't assert content type of no params test

* re-add cli arg

* jeez content-types are complicated

* update snapshot

* add c# dep on proxy

* un-change package-lock.json

---------

Co-authored-by: Jon Ursenbach <erunion@users.noreply.github.com>
Co-authored-by: Jon Ursenbach <jon@ursenba.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant