Skip to content

Fix 🐛 Bug #479: The Console has bunch of warnings - #480

Merged
atapas merged 17 commits into
mainfrom
issue-479
Aug 30, 2022
Merged

atapas merged 17 commits into
mainfrom
issue-479

Conversation

@Sachin-chaurasiya

@Sachin-chaurasiya Sachin-chaurasiya commented Aug 11, 2022 •

Copy link
Copy Markdown
Member

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

I worked on fixing issue #479

Fixes #479

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel

vercel Bot commented Aug 11, 2022 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Aug 30, 2022 at 7:44AM (UTC)

@koustov koustov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few initial question dropped

Comment thread src/common/services/request/index.js Resolved
Comment thread src/common/playlists/PlayList.jsx Resolved
Comment thread src/common/services/string.js Resolved
Comment thread src/plays/countries-statics/Country.jsx Resolved
Comment thread src/common/services/request/index.js Resolved
Comment thread src/common/playlists/PlayList.jsx Resolved
Comment thread src/common/playlists/PlayList.jsx Resolved
Comment thread src/common/services/string.js Resolved
Comment thread src/plays/countries-statics/Country.jsx Resolved
koustov
koustov previously approved these changes Aug 20, 2022

@koustov koustov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@koustov

koustov commented Aug 20, 2022

Copy link
Copy Markdown
Member

Crawler error
image

@atapas

atapas commented Aug 22, 2022

Copy link
Copy Markdown
Member

Crawler error image

Yep, very surprisingly, it never passes.

@atapas

atapas commented Aug 23, 2022

Copy link
Copy Markdown
Member

@Sachin-chaurasiya Any idea on it? I am clueless why this branch alone fails to build!

@Sachin-chaurasiya

Copy link
Copy Markdown
Member Author

@Sachin-chaurasiya Any idea on it? I am clueless why this branch alone fails to build!

Hey @atapas , I will have a look and if not working then will close this PR and open a new PR with the changes.

@koustov

koustov commented Aug 23, 2022 •

Copy link
Copy Markdown
Member

@Sachin-chaurasiya Any idea on it? I am clueless why this branch alone fails to build!

Hey @atapas , I will have a look and if not working then will close this PR and open a new PR with the changes.

It might be because of the dependency array. I can see the quoteArray is using a spread operator so its always a new instance. @Sachin-chaurasiya can you just remove the dependency and push once
image

@Sachin-chaurasiya

Sachin-chaurasiya commented Aug 24, 2022 •

Copy link
Copy Markdown
Member Author

@Sachin-chaurasiya Any idea on it? I am clueless why this branch alone fails to build!

Hey @atapas , I will have a look and if not working then will close this PR and open a new PR with the changes.

It might be because of the dependency array. I can see the quoteArray is using a spread operator so its always a new instance. @Sachin-chaurasiya can you just remove the dependency and push once image

@koustov , quoteArray is being used in that effect so we should have that in dependency right? it does not matter how we are using the quoteArray, only thing matter is what variable we are using for that effect.
If you want I can remove that but eslint will be complaining :)

@koustov

koustov commented Aug 24, 2022 •

Copy link
Copy Markdown
Member

quoteArray is being used in that effect so we should have that in dependency right?

I didn't try by myself however looking at the error (time out) I can only suspect something is blocking the crawler from passing through the component. It's my educated guess that the quotearray might be the issue. So what I am suggesting is, to remove the dependency and push a commit, if the crawler passes we know what was wrong and then we can take appropriate measurements before getting the PR merge. So, it's just a TRY, nothing more than that

@Sachin-chaurasiya

Copy link
Copy Markdown
Member Author

quoteArray is being used in that effect so we should have that in dependency right?

I didn't try by myself however looking at the error (time out) I can only suspect something is blocking the crawler from passing through the component. It's my educated guess that the quotearray might be the issue. So what I am suggesting is, to remove the dependency and push a commit, if the crawler passes we know what was wrong and then we can take appropriate measurements before getting the PR merge. So, it's just a TRY, nothing more than that

Sure, I will try that.

@Sachin-chaurasiya

Copy link
Copy Markdown
Member Author

Hey @koustov , Thanks man, after removing quoteArray from dependency it's working.

@koustov koustov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Sachin-chaurasiya

Copy link
Copy Markdown
Member Author

@atapas , Waiting for your review.

@atapas
atapas merged commit 8a5aac2 into main Aug 30, 2022
@atapas
atapas deleted the issue-479 branch August 30, 2022 09:06

This branch was successfully deployed

1 active deployment
Preview — b02db550 Deployed Aug 30, 2022 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: The Console has bunch of warnings

3 participants