Skip to content

when activities on, browse button is not visible in mobile view fixed - #1028

Closed
yeshwantthota wants to merge 4 commits into
reactplay:mainfrom
yeshwantthota:temp
Closed

yeshwantthota wants to merge 4 commits into
reactplay:mainfrom
yeshwantthota:temp

Conversation

@yeshwantthota

Copy link
Copy Markdown

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Browse button is not visible in the mobile view when activities are on, so in this commit I have fixed that bug.

Fixes # (issue)
#1019

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code

  • My changes generate no new warnings

Screenshots or example output

Screenshot (8)

@vercel

vercel Bot commented Mar 1, 2023

Copy link
Copy Markdown

@yeshwantthota is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

<span className="sr-only">Close</span>
</button>
</li>
{showToggleMenu && (

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yeshwantthota We should have the activities on condition also, right? Otherwise the toggle bar browse is going to appear in the default mode also.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, the activities condition should be on. so should I "on" the activities and then create another PR?

@vercel

vercel Bot commented Apr 20, 2023 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-play ❌ Failed (Inspect) Apr 24, 2023 4:46am

@github-actions

Copy link
Copy Markdown

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

@github-actions github-actions Bot added the stale label May 24, 2023
@github-actions github-actions Bot closed this May 31, 2023

This branch had an error being deployed

1 failed deployment
Preview — bfc02981 Deployed Apr 24, 2023 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: When activities on, the mobile view is missing the browse button

4 participants