You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
✨ [Feature request]: Add a link to navigate to all plays #280
There is already a React play home button at the top, we shall only include all plays button, what say @Sachin-chaurasiya @Programming-School-Pro-Coding
Reacted by Mohammed Ehab, Sachin Chaurasiya and Mohammed Taha
There is already a React play home button at the top, we shall only include all plays button, what say @Sachin-chaurasiya @Programming-School-Pro-Coding
But you are already on the plays page when this message appears. How about that?
There is already a React play home button at the top, we shall only include all plays button, what say @Sachin-chaurasiya @Programming-School-Pro-Coding
There is already a React play home button at the top, we shall only include all plays button, what say @Sachin-chaurasiya @Programming-School-Pro-Coding
But you are already on the plays page when this message appears. How about that?
I think we shouldn't overengineer this one. A reasonable fix to me is to enhance the message with the search text as you suggested. Can we get it done? I see the issue has been assigned to @vasantisuthar
I think we shouldn't overengineer this one. A reasonable fix to me is to enhance the message with the search text as you suggested. Can we get it done? I see the issue has been assigned to @vasantisuthar
There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!
Activity
Sachin-chaurasiya commentedon Jun 6, 2022
@vasantisuthar , One more thing we can do here is instead of
play not found, we can sayplay not found for {searchText}.MOHAMED-EHAB-DEV commentedon Jun 7, 2022
One more thing we can create two buttons one for the home page and the other is for plays page
vasantisuthar commentedon Jun 7, 2022
There is already a React play home button at the top, we shall only include all plays button, what say @Sachin-chaurasiya @Programming-School-Pro-Coding
atapas commentedon Jun 9, 2022
But you are already on the plays page when this message appears. How about that?
MOHAMED-EHAB-DEV commentedon Jun 9, 2022
Ok 👌
MOHAMED-EHAB-DEV commentedon Jun 9, 2022
In the 404 react file we will add new button
Sachin-chaurasiya commentedon Jun 9, 2022
@atapas , Your thought on this.
atapas commentedon Jun 30, 2022
@Sachin-chaurasiya
I think we shouldn't overengineer this one. A reasonable fix to me is to enhance the message with the search text as you suggested. Can we get it done? I see the issue has been assigned to @vasantisuthar
Sachin-chaurasiya commentedon Jun 30, 2022
@atapas , Yes.
Sachin-chaurasiya commentedon Jun 30, 2022
@vasantisuthar , Let me know, and I can pick this up.
vasantisuthar commentedon Jun 30, 2022
Okay so I can update the text message.
atapas commentedon Aug 2, 2022
@vasantisuthar / @Sachin-chaurasiya this issue is around for a long time. Can any of you please take care?
Sachin-chaurasiya commentedon Aug 2, 2022
Sure @atapas, @vasantisuthar let me know if you need any help on this.
vasantisuthar commentedon Aug 2, 2022
@Sachin-chaurasiya does it really need to be modified, I guess we shouldn't now as the page looks clear to me.
Sachin-chaurasiya commentedon Aug 2, 2022
@vasantisuthar , we can do something like this if there is a search term.
vasantisuthar commentedon Aug 2, 2022
Cool I will do it, I tried to do it before but the search bar wasn't shown up on the browser, so waited for that.
vasantisuthar commentedon Aug 4, 2022
Will submit this on Sunday
github-actions commentedon Dec 7, 2022
There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!
priyankarpal commentedon Oct 7, 2023
already added