Skip to content

✨ [Feature request]: Add a link to navigate to all plays #280

Closed

Description

@vasantisuthar

Add a link to navigate to all plays when play is not found

2022-06-05 (2)

It would be good if we add a text that will link to all the plays back when the play is not found.

I would like to work on this issue.

Activity

  1. Sachin-chaurasiya commented on Jun 6, 2022

    @Sachin-chaurasiya
    Member

    @vasantisuthar , One more thing we can do here is instead of play not found , we can say play not found for {searchText}.

  2. MOHAMED-EHAB-DEV commented on Jun 7, 2022

    @MOHAMED-EHAB-DEV
    Contributor

    One more thing we can create two buttons one for the home page and the other is for plays page

  3. vasantisuthar commented on Jun 7, 2022

    @vasantisuthar
    ContributorAuthor

    There is already a React play home button at the top, we shall only include all plays button, what say @Sachin-chaurasiya @Programming-School-Pro-Coding

  4. atapas commented on Jun 9, 2022

    @atapas
    Member

    There is already a React play home button at the top, we shall only include all plays button, what say @Sachin-chaurasiya @Programming-School-Pro-Coding

    But you are already on the plays page when this message appears. How about that?

  5. MOHAMED-EHAB-DEV commented on Jun 9, 2022

    @MOHAMED-EHAB-DEV
    Contributor

    There is already a React play home button at the top, we shall only include all plays button, what say @Sachin-chaurasiya @Programming-School-Pro-Coding

    Ok 👌

  6. MOHAMED-EHAB-DEV commented on Jun 9, 2022

    @MOHAMED-EHAB-DEV
    Contributor

    There is already a React play home button at the top, we shall only include all plays button, what say @Sachin-chaurasiya @Programming-School-Pro-Coding

    But you are already on the plays page when this message appears. How about that?

    In the 404 react file we will add new button

  7. Sachin-chaurasiya commented on Jun 9, 2022

    @Sachin-chaurasiya
    Member

    @vasantisuthar , One more thing we can do here is instead of play not found , we can say play not found for {searchText}.

    @atapas , Your thought on this.

  8. atapas commented on Jun 30, 2022

    @atapas
    Member

    @Sachin-chaurasiya

    I think we shouldn't overengineer this one. A reasonable fix to me is to enhance the message with the search text as you suggested. Can we get it done? I see the issue has been assigned to @vasantisuthar

  9. Sachin-chaurasiya commented on Jun 30, 2022

    @Sachin-chaurasiya
    Member

    @Sachin-chaurasiya

    I think we shouldn't overengineer this one. A reasonable fix to me is to enhance the message with the search text as you suggested. Can we get it done? I see the issue has been assigned to @vasantisuthar

    @atapas , Yes.

  10. Sachin-chaurasiya commented on Jun 30, 2022

    @Sachin-chaurasiya
    Member

    @vasantisuthar , Let me know, and I can pick this up.

  11. vasantisuthar commented on Jun 30, 2022

    @vasantisuthar
    ContributorAuthor

    Okay so I can update the text message.

  12. atapas commented on Aug 2, 2022

    @atapas
    Member

    @vasantisuthar / @Sachin-chaurasiya this issue is around for a long time. Can any of you please take care?

  13. Sachin-chaurasiya commented on Aug 2, 2022

    @Sachin-chaurasiya
    Member

    @vasantisuthar / @Sachin-chaurasiya this issue is around for a long time. Can any of you please take care?

    Sure @atapas, @vasantisuthar let me know if you need any help on this.

  14. vasantisuthar commented on Aug 2, 2022

    @vasantisuthar
    ContributorAuthor

    @Sachin-chaurasiya does it really need to be modified, I guess we shouldn't now as the page looks clear to me.

  15. Sachin-chaurasiya commented on Aug 2, 2022

    @Sachin-chaurasiya
    Member

    @Sachin-chaurasiya does it really need to be modified, I guess we shouldn't now as the page looks clear to me.

    @vasantisuthar , we can do something like this if there is a search term.

    image

  16. vasantisuthar commented on Aug 2, 2022

    @vasantisuthar
    ContributorAuthor

    Cool I will do it, I tried to do it before but the search bar wasn't shown up on the browser, so waited for that.

  17. vasantisuthar commented on Aug 4, 2022

    @vasantisuthar
    ContributorAuthor

    Cool I will do it, I tried to do it before but the search bar wasn't shown up on the browser, so waited for that.

    Will submit this on Sunday

  18. github-actions commented on Dec 7, 2022

    @github-actions

    There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

  19. reopened this on Sep 7, 2023
  20. priyankarpal commented on Oct 7, 2023

    @priyankarpal
    Member

    already added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions