Repository navigation
Endless loop when writing to disconnected socket #11
Description
Activity
@andreme sounds like you have a way to reproduce this, do you mind providing a gist? That would help in expediting a fix.
@steverhoades
It seems to be a windows only issue (Windows 7).
I tested this on debian and there is no problem.Run the server.php, run client.php in another terminal, kill the server with ctrl-c.
The client should hang after the 10 seconds are over.@clue
That helps, onData is called again once with $data == '', and then the client exits.
Am I using the wrong class? I'm not quite sure what the real difference is between them.I think I took it from the example here: https://github.com/reactphp/socket
Great, glad this solved the issue you were having!
The
React\Socketnamespace is part of thereact/socketpackage which is a "Library for building an evented socket server". Hence theReact\Socket\Connectionshould be used for an incoming connection and not for an outgoing one. And yes, this clearly needs a better documentation :)By the way, if you want to create an outgoing connection, I highly recommend using the react/socket-client package instead of handling the underlying
Streamyourself. I assume this is a pretty common requirement, so we should probably also mention this in this project's readme.Thanks guys.
In
Buffer->handleWrite()the result of fwrite is compared to false to check for errors.In my case it returns 0 (and fills lastError with
fwrite(): send of 49 bytes failed with errno=10054 An existing connection was forcibly closed by the remote host.).The check for
(0 === $sent && feof($this->stream))fails as well becausefeof($this->stream)returns false.Removing
&& feof($this->stream)fixes the problem.I use the socket server and socket client. When I kill the server process and the client tries to write something, it loops forever with 100% cpu.
For further reference: http://php.net/manual/en/function.fwrite.php#96951