You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Shouldn't a ConnectionFactory be passed into Server::__construct instead of having a hardcoded classname in createConnection?
According to the single responsibility principle usage of an object should be separate from its construction right?
@clue Yes I do, since it is hard to get traction for changing the ConnectionInterface (since not all connections have a port), it makes sense to have different connection interfaces and different underlying implementations. This would allow you to use such a different connection implementation without changing the server.
I believe this has been addressed via #65. Closing this due to a lack of feedback. If you feel this problem persists, please comment on this and we can reopen this 👍
Activity
clue commentedon Jul 12, 2016
I think this makes sense 👍 Out of curiosity, do you have any practical use case for this?
SamMousa commentedon Jul 12, 2016
@clue Yes I do, since it is hard to get traction for changing the
ConnectionInterface(since not all connections have a port), it makes sense to have different connection interfaces and different underlying implementations. This would allow you to use such a different connection implementation without changing the server.clue commentedon Jan 27, 2017
Ping @SamMousa, what do you think, is this and #47 still relevant now that #65 is in? 👍
clue commentedon Feb 8, 2017
I believe this has been addressed via #65. Closing this due to a lack of feedback. If you feel this problem persists, please comment on this and we can reopen this 👍