Division by zero in src/Server.php line 175 #360

Activity

1. clue

   added

   bug

   easy pick

   on Jun 5, 2020
2. clue

   added this to the v0.8.7 milestone on Jun 5, 2020
3. clue commented on Jun 5, 2020

   

   clue

   on Jun 5, 2020

   Member

   More actions

   @smscr Thanks for reporting, I can indeed reproduce this with post_max_size=0. Does anybody feel like filing a PR to address this? 👍

   In the meantime, you can work around this by setting post_max_size to a large value, this should have the same effect.
4. s-bronstein commented on Jun 5, 2020

   

   s-bronstein

   on Jun 5, 2020

   Author

   More actions

   @clue I've thought about a fix, and I see there is an intention to calculate an amount of request that can be handled concurrently, based on the memory limit and post_max_size.

   I'm not sure what amount of request we should estimate to be possible the the post_max_size is unlimited, so that is why I'm not suggesting a PR to address this.

   There could be several approaches.

   • To ignore the estimation and return self::MAXIMUM_CONCURRENT_REQUESTS? But what if the concurrent requests will exceed the memory then?
   • To limit to one concurrent request? But wouldn't that decrease the performance?
   • To change the estimation formula to use something other than post_max_size, but what in particular?
5. jsor

   closed this as completedin #365on Jul 4, 2020