Repository navigation
Server requestHandlers not concurrent, waits for response #334
Description
I found out, that Server requestHandlers are executed simultaneously waiting for response for preceding call.
I have make use case, where requestHandler returns promise that is resolve in $loop Timer after 2 seconds. In this 2 seconds, server and other connections is waiting. When the response is sent (it can be response with stream), next request is being processed.
Use case:
$socket = new \React\Socket\Server(SERVER_LISTEN . ':' . SERVER_PORT, $loop);
$socket->on('connection', function (ConnectionInterface $connection) {
echo $connection->getRemoteAddress() . "\tNew connection"));
});
$server = new \React\Http\Server(array(
new \React\Http\Middleware\LimitConcurrentRequestsMiddleware(10),
function($request) use ($loop) {
$reqId = \Nette\Utils\Random::generate(2, 'A-Z'); // Identify request by random ID
echo 'Request #' . $reqId . PHP_EOL;
$resolver = new \React\Promise\Deferred();
$loop->addTimer(2, function($request) use ($resolver, $reqId) {
$stream = new \React\Stream\ThroughStream();
echo 'Response #' . $reqId . PHP_EOL;
$resolver->resolve( new \React\Http\Response(
200,
['Content-Type' => 'text/event-stream; charset=utf-8'],
$stream
));
});
return $resolver->promise();
})
);
Trying 3 concurrent connections.
Expected possible output on STDOUT, running time about 2 seconds:
tcp://***:58924 New connection
tcp://***:58925 New connection
tcp://***:58940 New connection
Request #IX
Request #QC
Request #YI
Response #IX
Response #QC
Response #YI
The generated output. Make attention to order of request - response pair. Running time about 6 seconds.
tcp://***:58924 New connection
tcp://***:58925 New connection
tcp://***:58940 New connection
Request #IX
Response #IX
Request #QC
Response #QC
Request #YI
Response #YI
Activity
WyriHaximus commentedon Feb 20, 2019
What are you using to test this? There doesn't seem to be anything wrong with your code so I'm suspecting the issue might be on the requesting side. Also what are you using the empty
ThroughStreamfor?woytam commentedon Feb 20, 2019
I'm using
ApacheBench, Version 2.3 <$Revision: 1430300 $>The code is cutted from project, where
ThroughStreamis sending data on some events. Not in this use case.woytam commentedon Feb 20, 2019
Now, I have tested in two different browsers (updated
Content-Typetotext/html) and the result is the same.PHP v7.1.24 on CentOS 7, running in CLI
Edit
Composer.json of the project
WyriHaximus commentedon Feb 20, 2019
Can't seem to reproduce the issue you're seeing when using chrome and opening a few tabs in a row:
woytam commentedon Feb 20, 2019
Thanks @WyriHaximus for your support. I have tested it now on Windows and still no luck.
I have created gist with simple test case and composer.json for installation. For compatibility, I have used
StreamSelectLoop.But still getting serial processing (3 opened tabs in Firefox or Chrome):
As we can see, connections are in time parallel, but processing of request is waiting to resolving
ResponseinPromise.woytam commentedon Feb 20, 2019
I figured out, when used
StreamingServerinstead ofServer, it is working as expected - async.So, there will be probably problem with
LimitConcurrentRequestsMiddlewareintegrated inServer?If I specifically define
new \LimitConcurrentRequestsMiddleware(10)inrequestHandler, it will not overwrite the integrated one.In my case, problem is
memory_limitset to 128M andpost_max_sizealso 128M. So insideServerI getnew \LimitConcurrentRequestsMiddleware(1).WyriHaximus commentedon Feb 20, 2019
Glad to hear that you solved it. The
Serveris a convinence class that wrapsStreamingServerand several middleware to emulate PHP's behavior. You can influence those with the ini settings you mention. My suggestion would be to figure out a sane configuration for those ini settings for your application. If you need to handle128Mfile uploads you would need more then1Gof memory to handle 5 of those savely and concurrently. Dive into what is required for your application and adjust settings accordinglywoytam commentedon Feb 20, 2019
Thank you very much for your very quick help. I was a little confused about using
LimitConcurrentRequestsMiddleware.I have made a PR #335 with a small note about
LimitConcurrentRequestsMiddlewarewhen using basicServer.PS. My server needs tuning (php.ini) before production.