Skip to content

Why ringcentral/psr7 and not guzzle/psr7 #331

Description

@phpbg

Hi,

this is just a question, not an issue.

Why do you require ringcentral/psr7 from https://github.com/ringcentral/psr7 and not guzzle/psr7 from https://github.com/guzzle/psr7 ?

I see ringcentral is a fork of guzzle, but it doesn't explain why, and what's changed.

Wouldn't guzzle be a better choice?

Activity

  1. jsor commented on Nov 13, 2018

    @jsor
    Member

    See #319

  2. phpbg commented on Nov 13, 2018

    @phpbg
    Author

    Mmmhh ok, sorry for the duplicate.
    Don't you want to update the minimum requirements for react/http ?
    5.3 is quite obsolete now...
    Regards

  3. clue commented on Nov 13, 2018

    @clue
    Member

    "Why guzzle/psr7 and not ringcentral/psr7?" :-)

    I would argue that it doesn't really make much of a difference which PSR-7 implementation we're using. For the most part, this is an internal implementation detail that is not in any way exposed to the outside and our documentation explicitly says we're using PSR-7 interfaces only.

    While I can see where you're coming from, I don't think discussing PHP version requirements adds much to this specific discussion.

    Additionally, there are plans to drop RingCentral in a future version. Partly because it adds a lot of stuff that we don't really use here (sync file handling etc.) and partly because it's missing some stuff that we do need here (async implementations etc.).

    I believe this has been answered, so I'm closing this for now. Please come back with more details if this problem persists and we can reopen this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions