Skip to content

Allow ini-like filesizes #275

Closed
#278
Closed
Allow ini-like filesizes#275
#278
Labels
easy pickhelp wantednew feature
Milestone
v0.8.0

Description

@jsor
jsor
opened on Dec 8, 2017

A few constructors allow to pass file sizes as parameters. In addition to bytes as integers, we should allow string values similar to the ini settings like 8M.

Ref #274 (comment)
Affects also https://github.com/reactphp/http/blob/master/src/Middleware/RequestBodyBufferMiddleware.php#L16

Activity

  1. clue
    added
    easy pick
    help wanted
    new feature
    on Dec 9, 2017
  2. WyriHaximus
    added this to the v0.8.0 milestone on Dec 9, 2017
  3. WyriHaximus
    added a commit that references this issue on Dec 9, 2017

    Reverted implementing reactphp#275, doing that in a followup PR

    ad25edd
  4. clue
    closed this as completedin #278on Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    easy pickhelp wantednew feature

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions