Repository navigation
Consider removing Expect: 100-continue request header #262
Description
When we send 100 continue in https://github.com/reactphp/http/blob/master/src/Server.php#L225 shouldn‘t that header line be removed, similar to updating content length when buffering? Noticed this during building http proxy for php-pm.
Activity
WyriHaximus commentedon Nov 22, 2017
Can't find anything in the specs about having to remove it. Did you run into issues with it?
andig commentedon Nov 22, 2017
If I use the server to receive the request on proxy and slave side it will send the 100 twice which doesn‘t make sense?
WyriHaximus commentedon Nov 22, 2017
Good point, does makes sense to remove it then I suppose. What do you think @clue ?
[-]Remove expect header?[/-][+]Consider removing `Expect: 100-continue` request header[/+]clue commentedon Dec 8, 2017
I think you're raising a very valid point here! 👍 I would like to see what kind of implications this has, does anybody feel like filing a PR?
clue commentedon Mar 20, 2018
I'm closing this for now as it hasn't received any input in a while and I have no plans to change this myself anytime soon. Please come back if you feel this is still an issue and we can reopen this 👍