Repository navigation
Merge HttpClient component into this component #148
Description
Activity
- added this to the milestone
on Nov 28, 2017 they share quite a bit of common code.
Could you point out which code they share? When looking at the code I could not find anything obvious.
Could you point out which code they share? When looking at the code I could not find anything obvious.
Good point. You're right in that they currently don't share much code (except for chunked transfer encoding maybe). However, they share quite a bit of domain knowledge. In particular, we've had to backport fixes / minor features from this component to the http-client repeatedly.
Also, looking at its roadmap (reactphp/http-client#79) reveals that we plan to implement PSR-7 interfaces (reactphp/http-client#41) also for the http-client. Once this is in, they will share significantly more code.
Here's the current situation:
This is not exactly ideal, they share quite a bit of common code.
Also, I believe this situation may be a bit confusing for consumers of this package. In particular our Datagram component provides both client and server side for datagram sockets (UDP).
As such, I'd vote for merging these two components into a single Http component.