You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
👍 , fully agree on adding this. My main concern is how to do it non-blocking. A child process could be an option unless you know a good way to do it streaming chunk by chunk in future ticks.
Gzip encoding/decoding should in fact not actually be part of this library. It should be added as a dependency here.
I suppose it makes sense to build this on top of PHP's ZLib functions. I've started looking into building a streaming gzip encoder/decoder a while ago but have never been quite happy with its API.
Can't promise anything, but I'll try to look into this 👍
It should not be part of this library at all but we need to find a way to make it non-blocking so we can use it within this library. A streaming encoder/decoder sounds great and that is something we could use in react/http as well.
For the reference again, I've pushed an initial v0.1.0 release of clue/zlib-react a few days ago. This can now be integrated here to offer HTTP compression support (gzip and/or deflate).
Activity
WyriHaximus commentedon Sep 3, 2015
👍 , fully agree on adding this. My main concern is how to do it non-blocking. A child process could be an option unless you know a good way to do it streaming chunk by chunk in future ticks.
clue commentedon Sep 3, 2015
Gzip encoding/decoding should in fact not actually be part of this library. It should be added as a dependency here.
I suppose it makes sense to build this on top of PHP's ZLib functions. I've started looking into building a streaming gzip encoder/decoder a while ago but have never been quite happy with its API.
Can't promise anything, but I'll try to look into this 👍
WyriHaximus commentedon Sep 3, 2015
It should not be part of this library at all but we need to find a way to make it non-blocking so we can use it within this library. A streaming encoder/decoder sounds great and that is something we could use in react/http as well.
clue commentedon Sep 3, 2015
IMO this is a non-issue for two reasons:
This means that using a blocking decompressing algorithm for individual chunks can be considered non-blocking for the purpose of this library :-)
(Obviously, this doesn't apply if you're decompressing a multi-megabyte string variable – which does not apply to this library)
clue commentedon Nov 5, 2015
Just for the reference, I've started looking into the available implementation approaches a few weeks ago: clue/reactphp-zlib#1
Using PHP's zlib stream filters works okay-ish. I'm currently working around some of its limitations:
clue/reactphp-zlib#3 (comment)
clue commentedon Nov 15, 2015
For the reference again, I've pushed an initial v0.1.0 release of clue/zlib-react a few days ago. This can now be integrated here to offer HTTP compression support (
gzipand/ordeflate).I hear @WyriHaximus is working on this? 👍
WyriHaximus commentedon Nov 15, 2015
Not just working on it, I have a working prototype getting molded into a PR :)
WyriHaximus commentedon Jul 12, 2019
@CharlotteDunois about 3 and a half years old now so no clue. Feel free to build something because it has been ages
clue commentedon Jul 12, 2020
I have to close this one as per #152 now that future development will focus on https://github.com/reactphp/http instead.
I've migrated this ticket to reactphp/http#377.