Repository navigation
PHP 8 support #89
Description
I'm trying to use react/filesystem with PHP 8:
PHP 8.0.0RC3 (cli) (built: Oct 29 2020 21:25:02) ( NTS )
Copyright (c) The PHP Group
Zend Engine v4.0.0-dev, Copyright (c) Zend Technologies
But on composer install I got:
Problem 1
- wyrihaximus/react-child-process-pool[1.3.0, ..., 1.4.2] require php ^5.4||^7.0 -> your php version (8.0.0RC3) does not satisfy that requirement.
- wyrihaximus/react-child-process-pool[1.5.0, ..., 1.6.0] require php ^7.0 || ^5.4 -> your php version (8.0.0RC3) does not satisfy that requirement.
- react/filesystem v0.1.2 requires wyrihaximus/react-child-process-pool ^1.3 -> satisfiable by wyrihaximus/react-child-process-pool[1.3.0, ..., 1.6.0].
- Root composer.json requires react/filesystem ^0.1.2 -> satisfiable by react/filesystem[v0.1.2].
It seems that the transitive dependency wyrihaximus/react-child-process-pool can't be used with PHP 8.
Do you have any plan on supporting PHP 8? Thanks.
Activity
xtrime-ru commentedon Nov 4, 2020
Have you tried
composer install --ignore-platform-reqs?cheeghi commentedon Nov 5, 2020
Thank you for the response, of course ignoring the php version it works, but I think:
WyriHaximus commentedon Nov 5, 2020
@cheeghi since those are my packages I'll have a look at adding PHP8 support
cheeghi commentedon Nov 5, 2020
@WyriHaximus Ok thanks
WyriHaximus commentedon Nov 27, 2020
@cheeghi FYI I haven't forgotten about this and updated a lot of the underlying packages to support PHP 8. There are 3 left to do, two of them do all the messaging and pooling, I'll tag a release that adds the most bare PHP 8 support possible, and do a major release that fully supports PHP 7 features and also works on PHP 8.
cheeghi commentedon Nov 27, 2020
@WyriHaximus Thanks for the info, I can imagine there's some work to do, hope can be released soon!
WyriHaximus commentedon Nov 27, 2020
@cheeghi The packages done so far are significantly smaller, 2/3 of what is left is a lot bigger so using a different short term strategy for them.
holtkamp commentedon Jan 22, 2021
@WyriHaximus in #89 (comment) you mention a "bare minimum version that works on PHP 8", is that something I can find here: https://github.com/WyriHaximus/reactphp-child-process-pool ?
WyriHaximus commentedon Jan 22, 2021
@holtkamp So https://github.com/WyriHaximus/reactphp-child-process-pool relies on https://github.com/WyriHaximus/reactphp-child-process-messenger and that doesn't work on PHP 8 yet
valzargaming commentedon Jan 22, 2021
I was able to install this into DiscordPHP by using --ignore-platform-reqs in composer and was able to get some functionality working, but most things will either fail silently or throw a 500 internal server error. Most notably with PHP 8 changes, Windows stills seems to have issues with pipes but can use stdio sockets to achieve similar results.
WyriHaximus commentedon Jan 22, 2021
@valzargaming Yeah which is why https://github.com/WyriHaximus/reactphp-child-process-messenger uses TCP sockets to communicate with the child processes.
Anyway, about to round off work around a set of my ReactPHP packages today. Picking up related packages for this after that, the messenger package is going to be fun 🤐 .
clue commentedon Jan 25, 2021
@cheeghi Thanks for bringing this up!
I'm currently in the process of updating the test suites for all ReactPHP component and will add PHP 8 as a test target along the way 👍 We've verified PHP 8 works fine for most components via manual tests (e.g. reactphp/http#391), but couldn't add this to our CI setup due to a lack of support in Travis. I'll address this as soon as reactphp/reactphp#442 is merged, so this is definitely in the works and shouldn't take too long before everything is in
On top of this, this project currently depends on a few external libraries maintained by others. @WyriHaximus already pointed out he's working on an update these, looking forward to an update 👍
Additionally, we're in the process of reworking this project's API (#46 and #90), so there's hope we will be able to simplify this somewhat and also support more platforms in the future 👍
WyriHaximus commentedon Feb 1, 2021
An update on this, since this weekend I've been spending an hour a day or more working on updating https://github.com/WyriHaximus/reactphp-child-process-messenger to PHP 7.4 and to get it working on PHP 8. FYI releases will be done in such a way there is no new release required on
react/filesystemto get PHP 8 support out.isfar commentedon Jun 2, 2021
@WyriHaximus any update so far?
WyriHaximus commentedon Jun 6, 2021
@isfar Almost there, this is the last piece: WyriHaximus/reactphp-child-process-pool#57 (comment)
WyriHaximus commentedon Jun 19, 2021
FYI I'm aware and looking into which angle to fix this from: WyriHaximus/reactphp-child-process-pool#69 (comment)
WyriHaximus commentedon Jul 4, 2021
Just did a few releases resolving this issue. Please reopen this issue if it somehow persists for you.