Skip to content

Create tagged release #2

Description

@clue

Now that the source is imported, we should start adding tags so others can rely on this package.

This package was imported from clue/datagram which already had several tags. These were left out intentionally as this would introduce unnecessary noise in this repository (IMHO).

Ideally, we would release this as v1.0.0 and clean up the CHANGELOG accordingly.

Activity

  1. cboden commented on Sep 4, 2014

    @cboden
    Member

    There was talk of incorporation between DNS, datagram, and stream since there's somewhat a circular dependancy between them. Should we hold off on a v1.0 tag until that is figured out?

  2. clue commented on Sep 6, 2014

    @clue
    MemberAuthor

    The datagram and socket-client (I assume "stream" must have been a typo?) components operate on a different OSI layer than the DNS (edit: datagram) component, so I'm all for keeping them as separate packages.

    In fact, both components do not really require the DNS (edit: datagram) component at all. It's merely a convenience feature that allows you to pass hostnames instead of the underlying IP addresses. From a purely functional view-point I'd vote to remove the dependency on the DNS component - though from a practical viewpoint I'd vote to keep it as-is. So if we are to change our repo layout, I'd vote to split the repos here (e.g. datagram-with-dns and datagram-without-dns) to avoid the circular dependency.

    That being said, I agree that a circular dependency isn't quite ideal either. It's certainly testament of a design flaw, but other than that, does it really do any harm?

  3. attockonian commented on Oct 14, 2014

    @attockonian

    Any update on getting tags setup?

    @cboden I am working on name server implementation for DNS @ reactphp/dns#9 and plan on including Datagram as a dependency. Please advise on how dependency needs to be handled for the mentioned PR.

    Thanks

  4. cboden commented on Oct 19, 2014

    @cboden
    Member

    👍

    I'm good for you to tag v1.0 @clue

  5. clue commented on Oct 23, 2014

    @clue
    MemberAuthor

    Finally done, updated CHANGELOG and tagged v1.0.0 release (a476b74).

  6. attockonian commented on Oct 24, 2014

    @attockonian

    Thanks @clue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions