Skip to content

refactor: drop bytebuffer, fs-extra, node-fetch and form-data #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunnylqm merged 5 commits into from
Oct 12, 2026
Merged

refactor: drop bytebuffer, fs-extra, node-fetch and form-data #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d893c31
refactor(apk): decode resources.arsc with Buffer instead of bytebuffer
sunnylqm Oct 12, 2026
1653c61
fix(apk): decode UTF-16 resource string pools as UTF-16
sunnylqm Oct 12, 2026
78616f5
refactor: drop fs-extra for node:fs
sunnylqm Oct 12, 2026
4fab940
refactor(upload): stream uploads over node:http, drop node-fetch and …
sunnylqm Oct 12, 2026
fbdd8c2
fix: address review on emptyDirSync, upload size and dead catch blocks
sunnylqm Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 1 addition & 43 deletions bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 0 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,19 +62,15 @@
"homepage": "https://github.com/reactnativecn/react-native-update-cli",
"dependencies": {
"bplist-parser": "^0.3.2",
"bytebuffer": "^5.0.1",
"cgbi-to-png": "^1.0.7",
"chalk": "4",
"cli-arguments": "^0.2.1",
"compare-versions": "^6.1.1",
"filesize-parser": "^1.5.2",
"form-data": "^4.0.6",
"fs-extra": "^11.4.0",
"global-dirs": "^4.0.0",
"gradle-to-js": "^2.0.1",
"https-proxy-agent": "^7.0.6",
"i18next": "^26.4.0",
"node-fetch": "^2.6.1",
"plist": "^5.0.0",
"progress": "^2.0.3",
"properties": "^1.2.1",
Expand All @@ -98,9 +94,7 @@
"@biomejs/biome": "^2.5.10",
"@types/bun": "^1.4.0",
"@types/filesize-parser": "^1.5.3",
"@types/fs-extra": "^11.0.4",
"@types/node": "^26.3.0",
"@types/node-fetch": "^2.6.13",
"@types/progress": "^2.0.7",
"@types/yauzl": "^3.4.0",
"@types/yazl": "^3.3.1",
Expand Down
11 changes: 6 additions & 5 deletions scripts/fuzz-hermes-base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,11 @@
* caught with useful coverage, 1 otherwise; invalid arguments exit 2.
*/
import { spawnSync } from 'node:child_process';
import fs from 'fs-extra';
import fs from 'fs';
import os from 'os';
import path from 'path';
import { failureFingerprint } from '../src/utils/failure-fingerprint';
import { ensureDirSync, removeSync } from '../src/utils/fs-helpers';
import { compareHermesBytecode } from '../src/utils/hermes-base';
import { fuzzStringLiterals } from './hermes-fuzz-literals';
import { hermesFuzzSucceeded } from './hermes-fuzz-result';
Expand Down Expand Up @@ -580,7 +581,7 @@ interface Finding {
async function main() {
const rng = new Rng(SEED);
const gen = new Gen(rng);
fs.ensureDirSync(OUT_DIR);
ensureDirSync(OUT_DIR);
console.log(
`fuzz-hermes-base: ${ROUNDS} rounds, seed ${SEED}, hermesc ${hermesc}, out ${OUT_DIR}`,
);
Expand All @@ -598,7 +599,7 @@ async function main() {

for (let round = 0; round < ROUNDS; round++) {
const dir = path.join(OUT_DIR, `round-${String(round).padStart(4, '0')}`);
fs.ensureDirSync(dir);
ensureDirSync(dir);
const next = gen.program();
const baseSource =
pool.length > 0 && rng.chance(0.5) ? rng.pick(pool) : gen.mutate(next);
Expand Down Expand Up @@ -712,7 +713,7 @@ async function main() {
}
}

if (!keep) fs.removeSync(dir);
if (!keep) removeSync(dir);
}

const seconds = ((Date.now() - started) / 1000).toFixed(1);
Expand Down Expand Up @@ -751,7 +752,7 @@ async function main() {
plantedCompileErrors,
});
if (!ok) console.log(`\nfailing cases kept under ${OUT_DIR}`);
else if (!argValue('out')) fs.removeSync(OUT_DIR);
else if (!argValue('out')) removeSync(OUT_DIR);
process.exit(ok ? 0 : 1);
}

Expand Down
2 changes: 1 addition & 1 deletion scripts/smoke-lib.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ async function proxyScenario() {
});
});
// tunnels to the mock host: the API client (undici), the registry check
// (http.get) and the upload (node-fetch) each open their own
// (http.get) and the upload (http.request) each open their own
const tunnels = () =>
seenByProxy.filter((line) => line === `CONNECT 127.0.0.1:${apiPort}`)
.length;
Expand Down
Loading
Loading