Skip to content

update-react-imports changes line endings (LF -> CRLF) #281

Open

Description

@tpettrov

I recently started update-react-imports and it works as expected but re-wrote the line endings from LF to CRLF, probably because I'm on Windows but would expect that it doesn't change them if possible.

Activity

  1. threepointone commented on Oct 22, 2020

    @threepointone
    Contributor

    This is functionality from jscodeshift, so the issue should probably be filed there. However, one of the assumptions we have about people running codemods, is that they also run something like prettier (or whatever your code formatter is) manually after running the codemod. Does that advice seem reasonable in this case?

  2. tpettrov commented on Oct 22, 2020

    @tpettrov
    Author

    Advice is reasonable due to the fact that the issue should probably be filled to jscodeshift :) Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions