Skip to content
This repository was archived by the owner on Jul 19, 2019. It is now read-only.
This repository was archived by the owner on Jul 19, 2019. It is now read-only.

Options doesn't work with React 16 #210

Open

Description

@stelro

Hello, I am using react-chartjs version 1.2.0 and chart.js 1.1.1 and I have upgraded my App to react.js 16 and I have some issues with react-chartjs.

When I was using the module with react 15, everything was working alright like in the picture below
https://imgur.com/a/ueUOg
But since I upgraded to React 16, the options object sees to have broke, nothing is working as expected
https://imgur.com/MaFruaA .

Any suggestions?

Activity

  1. changed the title [-]Options doesn't work with React !6[/-] [+]Options doesn't work with React 16[/+] on Feb 3, 2018
  2. tankorsmash commented on May 25, 2018

    @tankorsmash

    I was looking at the v16 changelog and it mentions some stuff was changed around with React's lifecycle, but it doesn't seem to be the case. Can't figure this out either.

  3. Jareechang commented on May 25, 2018

    @Jareechang
    Collaborator

    @stelro, can you please upload an example ?

  4. katiawheeler commented on Aug 7, 2018

    @katiawheeler

    Any update on this?

  5. agent3bood commented on Oct 12, 2018

    @agent3bood

    I have made this pen as an example and it is working fine
    https://codepen.io/agent3bood/pen/bmrbqp?editors=0010
    If the issue something else please tell me so I can work on it.

  6. fdalvi commented on Nov 12, 2018

    @fdalvi

    @agent3bood, I just added a few options that do not work to your codepen: https://codepen.io/anon/pen/MzjNQw?editors=0010

    Hope this helps!

  7. agent3bood commented on Nov 12, 2018

    @agent3bood

    @fdalvi I think you referring to some options in chart.js version 2.
    This library support only chart.js version 1.1.1, please refer the docs here
    https://github.com/chartjs/Chart.js/tree/v1.1.1/docs
    Here is an idea for you
    Instead of padding you can use offsetGridLines: True

  8. fdalvi commented on Nov 13, 2018

    @fdalvi

    Thanks @agent3bood, you are absolutely correct! I actually switched to react-chartjs-2 since it uses the latest (and probably better supported) Chart.js library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions